Issue 668055: Added tests for issue 618

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 668055: Added tests for issue 618 (Closed)

Created:
10 years, 9 months ago by Søren Thygesen Gjesse

Modified:
9 years, 7 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Added tests for issue 618 Committed: http://code.google.com/p/v8/source/detail?r=4025

Patch Set 1 #

Total comments: 1

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+91 lines, -0 lines)			Patch
M	test/cctest/cctest.status	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	test/cctest/test-api.cc	View	1 chunk	+44 lines, -0 lines	0 comments	Download
A	test/mjsunit/bugs/bug-618.js	View	1 chunk	+45 lines, -0 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

10 years, 9 months ago (2010-03-04 12:10:27 UTC) #2

LGTM

http://codereview.chromium.org/668055/diff/1/4
File test/mjsunit/bugs/bug-618.js (right):

http://codereview.chromium.org/668055/diff/1/4#newcode28
test/mjsunit/bugs/bug-618.js:28: // When this bug is corrected move to
object-define-property and add
Left over comment?

Expand Messages | Collapse Messages