Issue 668015: Make --board mandatory in build_tests.sh. Also enable building with a default board.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 668015: Make --board mandatory in build_tests.sh. Also enable building with a default board. (Closed)

Created:
10 years, 9 months ago by davidjames

Modified:
9 years, 4 months ago

Reviewers:
kmixter1

CC:
chromium-os-reviews_chromium.org

Visibility:
Public.

Description

Make --board mandatory in build_tests.sh. Also enable building with a default board. BUG=none TEST=none

Patch Set 1 #

Total comments: 1

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -19 lines)			Patch
	M	src/scripts/build_tests.sh	View		1 chunk	+10 lines, -19 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

kmixter1

10 years, 9 months ago (2010-03-04 00:23:15 UTC) #2

LGTM

http://codereview.chromium.org/668015/diff/1/2
File src/scripts/build_tests.sh (right):

http://codereview.chromium.org/668015/diff/1/2#newcode25
src/scripts/build_tests.sh:25: if [ -z "$FLAGS_board" ]; then
nit: consistent use of "${var}" style

Expand Messages | Collapse Messages