Reland - Support msysgit in gcl and git-cl...

git_cl/git_cl.py

Index: git_cl/git_cl.py
===================================================================
--- git_cl/git_cl.py	(revision 77945)
+++ git_cl/git_cl.py	(working copy)
@@ -710,9 +710,14 @@
   fileobj.write(starting_text)
   fileobj.close()
 
-  result = None
+  # Open up the default editor in the system to get the CL description.
+  cmd = [editor, filename]
+  if sys.platform == 'win32' and 'mingw\\bin' in os.environ['PATH']:
+    # Msysgit requires the usage of 'env' to be present. The only way to
+    # accomplish that is by reading the environment variable for mingw\bin.
+    cmd.insert(0, 'env')
   try:
-    subprocess.check_call(['env', editor, filename], shell=True)
+    subprocess.check_call(cmd)

[TVL, 2011/03/14 13:31:54]

this has broken macosx and probably link when folks have editor set to things
like 'edit -w --resume'.  They needed to bounce through env to handle the fact
that editor is a command and not a single path.

[TVL, 2011/03/14 13:42:16]

Sorry, it's not env as much as shell=True.

[Mohamed Mansour, 2011/03/14 14:01:33]

Hi TVL, would changing cmd = [editor, filename] to "cmd = editor.split() +
[filename]" work ?

     fileobj = open(filename)
     result = fileobj.read()
     fileobj.close()