Pull the file picker code out of TabContents.

chrome/browser/file_select_helper.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_FILE_SELECT_HELPER_H_
 #define CHROME_BROWSER_FILE_SELECT_HELPER_H_
 #pragma once
 
 #include <vector>
 
+#include "base/compiler_specific.h"
 #include "chrome/browser/ui/shell_dialogs.h"
+#include "content/browser/tab_contents/tab_contents_observer.h"
 #include "content/common/notification_observer.h"
 #include "content/common/notification_registrar.h"
 #include "net/base/directory_lister.h"
 
 class Profile;
 class RenderViewHost;
 struct ViewHostMsg_RunFileChooser_Params;
 
 class FileSelectHelper
     : public SelectFileDialog::Listener,
       public net::DirectoryLister::DirectoryListerDelegate,
       public NotificationObserver {
  public:
   explicit FileSelectHelper(Profile* profile);
   ~FileSelectHelper();
 
-  // SelectFileDialog::Listener
-  virtual void FileSelected(const FilePath& path, int index, void* params);
-  virtual void MultiFilesSelected(const std::vector<FilePath>& files,
-                                  void* params);
-  virtual void FileSelectionCanceled(void* params);
-
-  // net::DirectoryLister::DirectoryListerDelegate
-  virtual void OnListFile(
-      const net::DirectoryLister::DirectoryListerData& data);
-  virtual void OnListDone(int error);
-
   // Show the file chooser dialog.
   void RunFileChooser(RenderViewHost* render_view_host,
                       const ViewHostMsg_RunFileChooser_Params& params);
 
  private:
-  // NotificationObserver implementation.
+  // SelectFileDialog::Listener overrides.
+  virtual void FileSelected(
+      const FilePath& path, int index, void* params) OVERRIDE;
+  virtual void MultiFilesSelected(const std::vector<FilePath>& files,
+                                  void* params) OVERRIDE;
+  virtual void FileSelectionCanceled(void* params) OVERRIDE;
+
+  // net::DirectoryLister::DirectoryListerDelegate overrides.
+  virtual void OnListFile(
+      const net::DirectoryLister::DirectoryListerData& data) OVERRIDE;
+  virtual void OnListDone(int error) OVERRIDE;
+
+  // NotificationObserver overrides.
   virtual void Observe(NotificationType type,
                        const NotificationSource& source,
-                       const NotificationDetails& details);
+                       const NotificationDetails& details) OVERRIDE;
 
   // Helper method for handling the SelectFileDialog::Listener callbacks.
   void DirectorySelected(const FilePath& path);
 
   // Helper method to get allowed extensions for select file dialog from
   // the specified accept types as defined in the spec:
   //   http://whatwg.org/html/number-state.html#attr-input-accept
   SelectFileDialog::FileTypeInfo* GetFileTypesFromAcceptType(
       const string16& accept_types);
 
@@ skipping 15 matching lines @@
   // The current directory lister results, which may update incrementally
   // as the listing proceeds.
   std::vector<FilePath> directory_lister_results_;
 
   // Registrar for notifications regarding our RenderViewHost.
   NotificationRegistrar notification_registrar_;
 
   DISALLOW_COPY_AND_ASSIGN(FileSelectHelper);
 };
 
+class FileSelectObserver : public TabContentsObserver {

[jam, 2011/03/11 17:03:58]

Why do we need a separate class, i.e. why not just make FileSelectHelper a
TabContentsObserver?  It doesn't look like it does anything heavyweight in its
constructor.

[Avi (use Gerrit), 2011/03/11 17:24:41]

Wish I could, but extensions/extension_host.h uses FileSelectHelper directly.

Perhaps in the future when we switch extensions to use the renamed TabContents,
we can, but for now we can't.

+ public:
+  explicit FileSelectObserver(TabContents* tab_contents);
+  ~FileSelectObserver();
+
+ private:
+  // TabContentsObserver overrides.
+  virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE;
+
+  // Called when a file selection is to be done.
+  void OnRunFileChooser(const ViewHostMsg_RunFileChooser_Params& params);
+
+  // FileSelectHelper, lazily created.
+  scoped_ptr<FileSelectHelper> file_select_helper_;
+
+  DISALLOW_COPY_AND_ASSIGN(FileSelectObserver);
+};
+
 #endif  // CHROME_BROWSER_FILE_SELECT_HELPER_H_