Issue 6679031: Disable the 8042 MUX on our x86 devices.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6679031: Disable the 8042 MUX on our x86 devices. (Closed)

Created:
9 years, 9 months ago by Duncan Laurie

Modified:
9 years, 7 months ago

Reviewers:
puneetster, Olof Johansson, Benson Leung

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, jimhebert, sosa

Base URL:
ssh://git@gitrw.chromium.org:9222/crosutils.git@master

Visibility:
Public.

Description

Disable the 8042 MUX on our x86 devices. The use of the mux can cause issues with some EC 8042 controllers and result in loss of keyboard/trackpad between suspend/resume/reboot cycles. We will never have more than keyboard+trackpad attached through the 8042 on our devices so using the mux is unnecessary. BUG=chrome-os-partner:2700 TEST=manual verification that mux is not probed at boot: Original: serio: i8042 KBD port at 0x60,0x64 irq 1 serio: i8042 AUX0 port at 0x60,0x64 irq 12 serio: i8042 AUX1 port at 0x60,0x64 irq 12 serio: i8042 AUX2 port at 0x60,0x64 irq 12 serio: i8042 AUX3 port at 0x60,0x64 irq 12 New: serio: i8042 KBD port at 0x60,0x64 irq 1 serio: i8042 AUX port at 0x60,0x64 irq 12 Change-Id: I942ab86eb71941ab072ad6a17d15b067ca94439d Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=4deda9c

Patch Set 1 #

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	build_kernel_image.sh	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Benson Leung

9 years, 9 months ago (2011-03-12 23:44:02 UTC) #3

On 2011/03/12 23:22:39, puneetster wrote:
> LGTM

LGTM.

Expand Messages | Collapse Messages