Issue 6679024: Removing 'off the record' references from TabRendererGtk. Contributed by vipul.bhasin@gmail.com

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6679024: Removing 'off the record' references from TabRendererGtk. Contributed by vipul.bhasin@gmail.com (Closed)

Created:
9 years, 9 months ago by Vipul

Modified:
9 years, 7 months ago

Reviewers:
msw, commit-bot: I haz the power, Elliot Glaysher

CC:
chromium-reviews, jam

Base URL:
http://git.chromium.org/git/chromium.git@trunk

Visibility:
Public.

Description

Removing 'off the record' references from TabRendererGtk BUG=3333 TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=78060

Patch Set 1 #

Total comments: 1

Patch Set 2 : Remove local variable and reference structure member directly #

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -11 lines)			Patch
M	chrome/browser/ui/gtk/browser_window_gtk.cc	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/gtk/tabs/tab_renderer_gtk.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/gtk/tabs/tab_renderer_gtk.cc	View	1	3 chunks	+3 lines, -4 lines	0 comments	Download
M	content/browser/worker_host/worker_message_filter.cc	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Vipul

Renamed TabRendererGtk::TabData::off_the_record to TabRendererGtk::TabData::incognito and updated references. Also renamed local variable names in BrowserWindowGtk's and ...

9 years, 9 months ago (2011-03-12 04:52:37 UTC) #1

msw

This looks good to me, but I'm just a provisional committer, so you'll need approval ...

9 years, 9 months ago (2011-03-12 19:45:55 UTC) #2

Change committed as 78060

Expand Messages | Collapse Messages