git_cl/git_cl.py - Issue 6679019: msysgit - Fix issue where git cl doesn't recognize editor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: git_cl/git_cl.py

Issue 6679019: msysgit - Fix issue where git cl doesn't recognize editor. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools/

Patch Set: Created 9 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: git_cl/git_cl.py

===================================================================

--- git_cl/git_cl.py (revision 77893)

+++ git_cl/git_cl.py (working copy)

@@ -651,7 +651,7 @@

fileobj.write(starting_text)

fileobj.close()

- ret = subprocess.call(editor + ' ' + filename, shell=True)

+ ret = subprocess.call(['env', editor, filename], shell=True)

M-A Ruel 2011/03/12 00:35:31 Same comment as for http://codereview.chromium.org

if ret != 0:

os.remove(filename)

return

« no previous file with comments | « no previous file | no next file » | no next file with comments »