msysgit - Fix issue where git cl doesn't recognize editor.

msysgit - Fix issue where git cl doesn't recognize editor.

The unix editor doesn't popup resulting in a unsuccessful upload. This change successfully fixes it.

BUG=70550
TEST=git cl upload works as expected under msysgit.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=77910

[Mohamed Mansour, 2011-03-12 00:05:53]

Added Aaron and Ryan, they might be interested in this change.

[Mohamed Mansour, 2011-03-12 00:15:10]

Added evan since he maintains git-cl

[M-A Ruel, 2011-03-12 00:35:31]

http://codereview.chromium.org/6679019/diff/1/git_cl/git_cl.py
File git_cl/git_cl.py (right):

http://codereview.chromium.org/6679019/diff/1/git_cl/git_cl.py#newcode654
git_cl/git_cl.py:654: ret = subprocess.call(['env', editor, filename],
shell=True)
Same comment as for http://codereview.chromium.org/6689001/

While at it, use check_call(), and use tempfile.NamedTemporaryFile() so you
don't need to remove it manually.

[Mohamed Mansour, 2011-03-12 02:04:59]

Hi Marc-Antoine, as we discussed on IM regarding Temporary files in msysgit has
permission issues.

[M-A Ruel, 2011-03-12 02:16:14]

lgtm

[M-A Ruel, 2011-03-12 02:17:42]

http://codereview.chromium.org/6679019/diff/6002/git_cl/git_cl.py
File git_cl/git_cl.py (right):

http://codereview.chromium.org/6679019/diff/6002/git_cl/git_cl.py#newcode713
git_cl/git_cl.py:713: result = None
not needed