Issue 6677172: Add option to not nuke Chrome to chrome_test.py

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6677172: Add option to not nuke Chrome to chrome_test.py (Closed)

Created:
9 years, 8 months ago by rkc

Modified:
9 years, 7 months ago

Reviewers:
Nirnimesh

CC:
chromium-os-reviews_chromium.org, sosa+cc_chromium.org, seano+cc_chromium.org, ericli, zel

Base URL:
http://git.chromium.org/git/autotest.git@master

Visibility:
Public.

Description

Add option to not nuke Chrome to chrome_test.py Current chrome_test.py nukes chrome and disables it's restart everytime we run BrowserTests. We're changng BrowserTests to run logged in instead, which is not possible if Chrome restart is disabled. Login code nukes chrome and expects it to restart for the login to occur. Using this flag allows us to turn off the nuke and allowing the login code to work. R=nirnimesh@chromium.org BUG=13857 TEST=Ran the autotest BrowserTest suite. Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=968752f

Patch Set 1 #

Total comments: 1

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -9 lines)			Patch
	M	client/cros/chrome_test.py	View		4 chunks	+16 lines, -9 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Nirnimesh

LGTM http://codereview.chromium.org/6677172/diff/1/client/cros/chrome_test.py File client/cros/chrome_test.py (right): http://codereview.chromium.org/6677172/diff/1/client/cros/chrome_test.py#newcode31 client/cros/chrome_test.py:31: def initialize(self, nuke_browser_norestart = True): remove space around ...

9 years, 8 months ago (2011-04-05 22:45:50 UTC) #2

The BUG= line is wrong. Use chromium-os:

Expand Messages | Collapse Messages