Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(944)

Unified Diff: chrome/browser/resources/gpu_internals/raw_events_view.js

Issue 6677166: More about:gpu tracing improvements. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/gpu_internals/raw_events_view.js
diff --git a/chrome/browser/resources/gpu_internals/raw_events_view.js b/chrome/browser/resources/gpu_internals/raw_events_view.js
index 5ff981a8f54586d4605c2457546a716ea353acea..1c4ff120339b8e9f261925db720e4d000eb2c05c 100644
--- a/chrome/browser/resources/gpu_internals/raw_events_view.js
+++ b/chrome/browser/resources/gpu_internals/raw_events_view.js
@@ -21,44 +21,52 @@ cr.define('gpu', function() {
__proto__: gpu.Tab.prototype,
decorate: function() {
- tracingController.addEventListener('traceBegun', this.refresh.bind(this));
- tracingController.addEventListener('traceEnded', this.refresh.bind(this));
- this.addEventListener('selectedChange', this.onSelectedChange_);
- this.refresh();
+ tracingController.addEventListener('traceBegun',
+ this.setNeedsRefresh_.bind(this));
+ tracingController.addEventListener('traceEnded',
+ this.setNeedsRefresh_.bind(this));
+ this.addEventListener('selectedChange', this.onViewSelectedChange_);
+
+ this.setNeedsRefresh_();
},
- onSelectedChange_: function() {
+ onViewSelectedChange_: function() {
if (this.selected) {
if (!tracingController.traceEvents.length) {
tracingController.beginTracing();
}
if (this.needsRefreshOnShow_) {
- this.needsRefreshOnShow_ = false;
this.refresh();
}
}
},
+ setNeedsRefresh_: function() {
+ if (!this.selected) {
+ this.needsRefreshOnShow_ = true;
+ return;
+ } else {
+ this.refresh();
+ }
+ },
+
/**
* Updates the view based on its currently known data
*/
refresh: function() {
- if (this.parentNode.selectedTab != this) {
- this.needsRefreshOnShow_ = true;
- }
+ this.needsRefreshOnShow_ = false;
var dataElement = this.querySelector('.raw-events-view-data');
if (tracingController.isTracingEnabled) {
var tmp = 'Still tracing. ' +
- 'Uncheck the enable tracing button to see traced data.';
+ 'Uncheck the enable tracing button to see traced data.';
dataElement.textContent = tmp;
} else if (!tracingController.traceEvents.length) {
dataElement.textContent =
'No trace data collected. Collect data first.';
} else {
var events = tracingController.traceEvents;
- var text = JSON.stringify(events);
- dataElement.textContent = text;
+ dataElement.textContent = JSON.stringify(events);
var selection = window.getSelection();
selection.removeAllRanges();

Powered by Google App Engine
This is Rietveld 408576698