Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(692)

Issue 6677165: Add feature to ctest that allows it to run against the latest image if no latest candidate exists. (Closed)

Created:
9 years, 8 months ago by sosa
Modified:
9 years, 6 months ago
Reviewers:
dgarrett
CC:
chromium-os-reviews_chromium.org, sosa
Visibility:
Public.

Description

Add feature to ctest that allows it to run against the latest image if no latest candidate exists. Change-Id: If5a3e0058a584204b940ad07c07b8b46268c993a BUG=chromium-os:10701 TEST=Ran ctest ... saw 100% pass rate. Ran from src/platform/crostestutils. Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=c507898

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add excepiton #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -15 lines) Patch
M ctest/ctest.py View 1 8 chunks +40 lines, -15 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
sosa
9 years, 8 months ago (2011-04-05 21:21:37 UTC) #1
sosa
9 years, 8 months ago (2011-04-05 21:21:37 UTC) #2
dgarrett
LGTM, with one comment. http://codereview.chromium.org/6677165/diff/1/ctest/ctest.py File ctest/ctest.py (right): http://codereview.chromium.org/6677165/diff/1/ctest/ctest.py#newcode160 ctest/ctest.py:160: except: I know you're just ...
9 years, 8 months ago (2011-04-05 23:36:38 UTC) #3
sosa
PTAL. Added additional Error class.
9 years, 8 months ago (2011-04-06 21:58:04 UTC) #4
dgarrett
9 years, 8 months ago (2011-04-06 22:10:02 UTC) #5
Excellent, thanks!  LGTM

Powered by Google App Engine
This is Rietveld 408576698