Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 6677164: Always iterate outgoing arguments as a part of caller frame. (Closed)

Created:
9 years, 8 months ago by Vyacheslav Egorov (Chromium)
Modified:
9 years, 7 months ago
Reviewers:
fschneider
CC:
v8-dev
Visibility:
Public.

Description

Always iterate outgoing arguments as a part of caller frame. Change caller_sp() to always point to the place after outgoing arguments. Change deoptimizer to use absolute stack slot addresses for deferred HeapNumber's materialization. (This is reapplication of r7504 with fix for mozilla testsuite failures). Committed: http://code.google.com/p/v8/source/detail?r=7516

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -161 lines) Patch
M src/deoptimizer.h View 4 chunks +10 lines, -38 lines 0 comments Download
M src/deoptimizer.cc View 13 chunks +22 lines, -62 lines 0 comments Download
M src/frames.h View 3 chunks +11 lines, -2 lines 1 comment Download
M src/frames.cc View 5 chunks +12 lines, -52 lines 0 comments Download
M src/frames-inl.h View 1 chunk +15 lines, -4 lines 0 comments Download
M src/runtime.cc View 1 chunk +4 lines, -3 lines 1 comment Download

Messages

Total messages: 3 (0 generated)
Vyacheslav Egorov (Chromium)
9 years, 8 months ago (2011-04-05 20:19:10 UTC) #1
Vyacheslav Egorov (Chromium)
Florian volunteered to review it.
9 years, 8 months ago (2011-04-06 10:54:11 UTC) #2
fschneider
9 years, 8 months ago (2011-04-06 14:06:55 UTC) #3
LGTM.

Thanks for refactoring of heap number materialization!

http://codereview.chromium.org/6677164/diff/1/src/frames.h
File src/frames.h (right):

http://codereview.chromium.org/6677164/diff/1/src/frames.h#newcode571
src/frames.h:571: return Smi::cast(GetExpression(0))->value();
Too much indentation.

http://codereview.chromium.org/6677164/diff/1/src/runtime.cc
File src/runtime.cc (right):

http://codereview.chromium.org/6677164/diff/1/src/runtime.cc#newcode7331
src/runtime.cc:7331: for (int i = 0; i < frames; i++) {
That's a little confusing to get to the bottom frame of the deopt. Can you just
write e.g.:

for (int i = 0; i < frames - 1; i++) it.Advance();

Powered by Google App Engine
This is Rietveld 408576698