Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(869)

Issue 6677157: Preparing to upstream: Created host_attributes and server_job_utils files. (Closed)

Created:
9 years, 8 months ago by pauldean_chromium
Modified:
9 years, 7 months ago
Reviewers:
ericli, ericli1
CC:
chromium-os-reviews_chromium.org, sosa+cc_chromium.org, seano+cc_chromium.org
Visibility:
Public.

Description

Preparing to upstream: Created host_attributes and server_job_utils files. Created a host_attributes file which by default doesn't do much on its own, but uses site_host_attributes when present to define attributes. The existing HostAttributes class did not change so no existing use should regress. Created a server_job_utils file to hold the helper classes test_item and machine_worker. These classes are used by distribute_across_machines to manage tests and machines. Change-Id: I4a5795bc7e6e865f616e4becf1e0781c1f51fe2b BUG=none. TEST=Run BVT with parallel_on_machines and distribute_across_machines on lab machines. Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=f807c18

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+216 lines, -177 lines) Patch
A server/host_attributes.py View 1 chunk +20 lines, -0 lines 0 comments Download
M server/server_job.py View 4 chunks +6 lines, -177 lines 0 comments Download
A server/server_job_utils.py View 1 chunk +190 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
pauldean_chromium
Hi Eric, Here are the changes to server_job we discussed to prepare it for upstreaming. ...
9 years, 8 months ago (2011-04-05 17:59:35 UTC) #1
ericli
9 years, 8 months ago (2011-04-05 18:22:24 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698