Issue 6677149: Append software rendering list version to the about:gpu page.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6677149: Append software rendering list version to the about:gpu page. (Closed)

Created:
9 years, 8 months ago by Zhenyao Mo

Modified:
9 years, 7 months ago

Reviewers:
zmo, nduca

CC:
chromium-reviews, arv (Not doing code reviews)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Append software rendering list version to the about:gpu page. BUG=none TEST=about:gpu page displays the SRL version. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=80464

Patch Set 1 : '' #

Total comments: 1

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+34 lines, -8 lines)			Patch
M	chrome/browser/gpu_data_manager.h	View	2 chunks	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/gpu_data_manager.cc	View	2 chunks	+16 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/gpu_internals/info_view.html	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/resources/gpu_internals/info_view.js	View	1 chunk	+4 lines, -0 lines	1 comment	Download
M	chrome/browser/ui/webui/gpu_internals_ui.cc	View	2 chunks	+10 lines, -7 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

nduca

LGTM. http://codereview.chromium.org/6677149/diff/3001/chrome/browser/resources/gpu_internals/info_view.js File chrome/browser/resources/gpu_internals/info_view.js (right): http://codereview.chromium.org/6677149/diff/3001/chrome/browser/resources/gpu_internals/info_view.js#newcode84 chrome/browser/resources/gpu_internals/info_view.js:84: description: 'Software rendering list version', GPU database version?

9 years, 8 months ago (2011-04-05 01:16:03 UTC) #2

zmo

9 years, 8 months ago (2011-04-05 04:10:34 UTC) #3

On 2011/04/05 01:16:03, nduca wrote:
> LGTM.
> 
>
http://codereview.chromium.org/6677149/diff/3001/chrome/browser/resources/gpu...
> File chrome/browser/resources/gpu_internals/info_view.js (right):
> 
>
http://codereview.chromium.org/6677149/diff/3001/chrome/browser/resources/gpu...
> chrome/browser/resources/gpu_internals/info_view.js:84: description: 'Software
> rendering list version',
> GPU database version?

Software rendering list is the "official" name.

Expand Messages | Collapse Messages