Handle changes in extension ID generation logic better.

chrome/browser/extensions/extension_prefs_unittest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/memory/scoped_temp_dir.h"
 #include "base/message_loop.h"
 #include "base/path_service.h"
 #include "base/stl_util-inl.h"
 #include "base/string_number_conversions.h"
 #include "base/stringprintf.h"
@@ skipping 593 matching lines @@
     EXPECT_TRUE(prefs()->WasAppDraggedByUser(extension_->id()));
   }
 
  private:
   scoped_refptr<Extension> extension_;
 };
 TEST_F(ExtensionPrefsAppDraggedByUser, ExtensionPrefsAppDraggedByUser) {}
 
 namespace keys = extension_manifest_keys;
 
+// Tests that we gracefully handle changes in the ID generation function for
+// unpacked extensions.
+class ExtensionPrefsIdChange : public ExtensionPrefsTest {
+ public:
+  virtual void Initialize() {
+    DictionaryValue manifest;
+    manifest.SetString(keys::kVersion, "1.0.0.0");
+    manifest.SetString(keys::kName, "unused");
+
+    extension_ = prefs_.AddExtensionWithManifest(
+        manifest, Extension::LOAD);
+
+    fprintf(stderr, "generated extension id: %s\n", extension_->id().c_str());

[asargent_no_longer_on_chrome, 2011/04/04 23:46:15]

nit: remove this debugging output, or switch to using VLOG 

[Mihai Parparita -not on Chrome, 2011/04/05 00:22:47]

Oops, removed.

+
+    DictionaryValue* extensions_dict =
+        prefs()->pref_service()->GetMutableDictionary(
+            ExtensionPrefs::kExtensionsPref);
+
+    Value* extension_prefs;
+    EXPECT_TRUE(extensions_dict->RemoveWithoutPathExpansion(
+        extension_->id(), &extension_prefs));
+    extensions_dict->SetWithoutPathExpansion(
+        "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa", extension_prefs);
+  }
+
+  virtual void Verify() {
+    prefs_.RecreateExtensionPrefs();
+    prefs()->SetExtensionState(extension_.get(), Extension::DISABLED);

[asargent_no_longer_on_chrome, 2011/04/04 23:46:15]

maybe add a check here that you get back the extension correctly by the expected
id?

[Mihai Parparita -not on Chrome, 2011/04/05 00:22:47]

Added a check using ExtensionPrefs::GetExtensions

+  }
+
+ private:
+  scoped_refptr<Extension> extension_;
+};
+TEST_F(ExtensionPrefsIdChange, IdChange) {}
+
 class ExtensionPrefsPreferencesBase : public ExtensionPrefsTest {
  public:
   ExtensionPrefsPreferencesBase()
       : ExtensionPrefsTest(),
         ext1_(NULL),
         ext2_(NULL),
         ext3_(NULL),
         installed() {
     DictionaryValue simple_dict;
     std::string error;
@@ skipping 288 matching lines @@
     testing::Mock::VerifyAndClearExpectations(v1i);
     testing::Mock::VerifyAndClearExpectations(v2);
     testing::Mock::VerifyAndClearExpectations(v2i);
   }
 
   virtual void Verify() {
   }
 };
 TEST_F(ExtensionPrefsSetExtensionControlledPref,
     ExtensionPrefsSetExtensionControlledPref) {}