Issue 6677146: AU: OmahaRequestAction: allow to be skipped.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6677146: AU: OmahaRequestAction: allow to be skipped. (Closed)

Created:
9 years, 8 months ago by adlr

Modified:
9 years ago

Reviewers:
petkov

CC:
chromium-os-reviews_chromium.org, petkov, adlr

Base URL:
http://git.chromium.org/git/update_engine.git@master

Visibility:
Public.

Description

AU: OmahaRequestAction: allow to be skipped. This CL changes OmahaRequestAction to take a request to skip its action when it's run. This will be useful in a future CL, where we'll want to schedule an OmahaRequestAction to run, but then in some cases prevent it from actually doing so. This also changes MockHttpFetcher to be able, if properly configured, to fail it it's used. This is used in the test to make sure that a skipped OmahaRequestAction does no HTTP traffic. BUG=chromium-os:13813 TEST=unittests Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=173e63c

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix include "" vs <> #

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+52 lines, -4 lines)			Patch
M	mock_http_fetcher.h	View		3 chunks	+8 lines, -1 line	0 comments	Download
M	mock_http_fetcher.cc	View	1	2 chunks	+7 lines, -2 lines	0 comments	Download
M	omaha_request_action.h	View		2 chunks	+5 lines, -0 lines	0 comments	Download
M	omaha_request_action.cc	View		2 chunks	+6 lines, -1 line	0 comments	Download
M	omaha_request_action_unittest.cc	View		1 chunk	+26 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

petkov

LGTM http://codereview.chromium.org/6677146/diff/1/mock_http_fetcher.cc File mock_http_fetcher.cc (right): http://codereview.chromium.org/6677146/diff/1/mock_http_fetcher.cc#newcode10 mock_http_fetcher.cc:10: #include "gtest/gtest.h" I thought we were switching these ...

9 years, 8 months ago (2011-04-04 23:33:28 UTC) #2

adlr

9 years, 8 months ago (2011-04-05 00:20:10 UTC) #3

fixed and pushed!

http://codereview.chromium.org/6677146/diff/1/mock_http_fetcher.cc
File mock_http_fetcher.cc (right):

http://codereview.chromium.org/6677146/diff/1/mock_http_fetcher.cc#newcode10
mock_http_fetcher.cc:10: #include "gtest/gtest.h"
On 2011/04/04 23:33:28, petkov wrote:
> I thought we were switching these to <>

You're right. Changed to <>

Expand Messages | Collapse Messages