courgette/win32_x86_generator.h - Issue 6677141: Switch out use of std::string and std::vector for large allocations for a buffer class that doesn...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: courgette/win32_x86_generator.h

Issue 6677141: Switch out use of std::string and std::vector for large allocations for a buffer class that doesn... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: fix linux build error. remove unnecessary call Created 9 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: courgette/win32_x86_generator.h

===================================================================

--- courgette/win32_x86_generator.h (revision 80344)

+++ courgette/win32_x86_generator.h (working copy)

@@ -27,8 +27,11 @@

}

Status WriteInitialParameters(SinkStream* parameter_stream) {

- parameter_stream->WriteSizeVarint32(old_element_->offset_in_ensemble());

- parameter_stream->WriteSizeVarint32(old_element_->region().length());

+ if (!parameter_stream->WriteSizeVarint32(

+ old_element_->offset_in_ensemble()) ||

+ !parameter_stream->WriteSizeVarint32(old_element_->region().length())) {

+ return C_STREAM_ERROR;

+ }

return C_OK;

// TODO(sra): Initialize |patcher_| with these parameters.

}

« no previous file with comments | « courgette/streams.cc ('k') | courgette/win32_x86_patcher.h » ('j') | no next file with comments »