chrome/installer/setup/setup_main.cc - Issue 6677141: Switch out use of std::string and std::vector for large allocations for a buffer class that doesn...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/installer/setup/setup_main.cc

Issue 6677141: Switch out use of std::string and std::vector for large allocations for a buffer class that doesn... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: fix linux build error. remove unnecessary call Created 9 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/installer/setup/setup_main.cc

===================================================================

--- chrome/installer/setup/setup_main.cc (revision 80344)

+++ chrome/installer/setup/setup_main.cc (working copy)

@@ -510,7 +510,8 @@

FilePath unpack_path(temp_path.path().Append(installer::kInstallSourceDir));

if (UnPackArchive(archive, installer_state, temp_path.path(), unpack_path,

archive_type)) {

- install_status = installer::UNCOMPRESSION_FAILED;

+ install_status = (*archive_type) == installer::INCREMENTAL_ARCHIVE_TYPE ?

+ installer::APPLY_DIFF_PATCH_FAILED : installer::UNCOMPRESSION_FAILED;

InstallUtil::WriteInstallerResult(system_install,

installer_state.state_key(), install_status,

IDS_INSTALL_UNCOMPRESSION_FAILED_BASE, NULL);

« no previous file with comments | « no previous file | chrome/installer/setup/setup_util.cc » ('j') | no next file with comments »