Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Unified Diff: courgette/encoded_program.h

Issue 6677141: Switch out use of std::string and std::vector for large allocations for a buffer class that doesn... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: courgette/encoded_program.h
===================================================================
--- courgette/encoded_program.h (revision 80344)
+++ courgette/encoded_program.h (working copy)
@@ -1,4 +1,4 @@
-// Copyright (c) 2009 The Chromium Authors. All rights reserved.
+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
@@ -37,6 +37,8 @@
void EndLabels();
// (3) Add instructions in the order needed to generate bytes of file.
+ // NOTE: If any of these methods ever fail, the EncodedProgram instance
+ // has failed and should be discarded.
CheckBool AddOrigin(RVA rva);
CheckBool AddCopy(uint32 count, const void* bytes);
CheckBool AddRel32(int label_index);
@@ -68,10 +70,10 @@
OP_LAST
};
- typedef std::vector<RVA, MemoryAllocator<RVA> > RvaVector;
- typedef std::vector<uint32, MemoryAllocator<uint32> > UInt32Vector;
- typedef std::vector<uint8, MemoryAllocator<uint8> > UInt8Vector;
- typedef std::vector<OP, MemoryAllocator<OP> > OPVector;
+ typedef NoThrowBuffer<RVA> RvaVector;
+ typedef NoThrowBuffer<uint32> UInt32Vector;
+ typedef NoThrowBuffer<uint8> UInt8Vector;
+ typedef NoThrowBuffer<OP> OPVector;
void DebuggingSummary();
CheckBool GenerateBaseRelocations(SinkStream *buffer);

Powered by Google App Engine
This is Rietveld 408576698