Issue 6677090: Fix the owners implementation to validate method inputs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6677090: Fix the owners implementation to validate method inputs. (Closed)

Created:
9 years, 9 months ago by Dirk Pranke

Modified:
9 years, 7 months ago

Reviewers:
chase, M-A Ruel

CC:
chromium-reviews, M-A Ruel

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools/

Visibility:
Public.

Description

Fix the owners implementation to validate method inputs. R=chase@chromium.org,maruel@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=78454

Patch Set 2 : '' #

Total comments: 2

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+45 lines, -4 lines)			Patch
	M	owners.py	View		4 chunks	+15 lines, -4 lines	2 comments	Download
	M	tests/owners_unittest.py	View		2 chunks	+30 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

M-A Ruel

http://codereview.chromium.org/6677090/diff/3001/owners.py File owners.py (right): http://codereview.chromium.org/6677090/diff/3001/owners.py#newcode93 owners.py:93: def _check_collection(self, obj): I prefer this function to not ...

9 years, 9 months ago (2011-03-17 01:27:47 UTC) #3

Dirk Pranke

9 years, 9 months ago (2011-03-17 01:30:17 UTC) #4

On 2011/03/17 01:27:47, Marc-Antoine Ruel wrote:
> http://codereview.chromium.org/6677090/diff/3001/owners.py
> File owners.py (right):
> 
> http://codereview.chromium.org/6677090/diff/3001/owners.py#newcode93
> owners.py:93: def _check_collection(self, obj):
> I prefer this function to not be a member function. It has no relation to the
> object.
> 

Fair enough. I mostly hung it off of there so as to not clutter up the module
with free functions (though I prefer free functions to static methods).

Expand Messages | Collapse Messages

Issue 6677090: Fix the owners implementation to validate method inputs. (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Messages