Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Issue 6677064: Remove last dependencies on chrome\common from chrome\plugin. (Closed)

Created:
9 years, 9 months ago by jam
Modified:
9 years, 6 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, darin-cc_chromium.org, jam, stuartmorgan+watch_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Remove last dependencies on chrome\common from chrome\plugin. TBR=avi Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=78372

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -92 lines) Patch
M chrome/browser/renderer_host/browser_render_process_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tab_contents/thumbnail_generator.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_common.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/common/chrome_content_client.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/chrome_content_client.cc View 2 chunks +23 lines, -1 line 0 comments Download
D chrome/common/section_util_win.h View 1 chunk +0 lines, -23 lines 0 comments Download
D chrome/common/section_util_win.cc View 1 chunk +0 lines, -29 lines 0 comments Download
M chrome/plugin/plugin_channel.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/plugin/plugin_main.cc View 2 chunks +1 line, -6 lines 0 comments Download
M chrome/plugin/plugin_thread.cc View 3 chunks +5 lines, -20 lines 0 comments Download
M chrome/plugin/webplugin_delegate_stub.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/plugin/webplugin_proxy.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/content_client.h View 2 chunks +2 lines, -1 line 0 comments Download
A + content/common/section_util_win.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/common/section_util_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/content_common.gypi View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jam
9 years, 9 months ago (2011-03-15 22:08:13 UTC) #1
Avi (use Gerrit)
9 years, 9 months ago (2011-03-15 22:23:33 UTC) #2
rubber-stamp LGTM

Powered by Google App Engine
This is Rietveld 408576698