Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1891)

Unified Diff: chrome/plugin/webplugin_proxy.cc

Issue 6677053: Get rid of some more dependencies on chrome\common from plugin, in preparatio... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/plugin/webplugin_delegate_stub.cc ('k') | content/common/plugin_carbon_interpose_constants_mac.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/plugin/webplugin_proxy.cc
===================================================================
--- chrome/plugin/webplugin_proxy.cc (revision 78225)
+++ chrome/plugin/webplugin_proxy.cc (working copy)
@@ -10,12 +10,11 @@
#include "base/scoped_handle.h"
#include "base/shared_memory.h"
#include "build/build_config.h"
-#include "chrome/common/child_process_logging.h"
-#include "chrome/common/url_constants.h"
#include "chrome/plugin/npobject_proxy.h"
#include "chrome/plugin/npobject_util.h"
#include "chrome/plugin/plugin_channel.h"
#include "chrome/plugin/plugin_thread.h"
+#include "content/common/content_client.h"
#include "content/common/plugin_messages.h"
#include "skia/ext/platform_device.h"
#include "third_party/WebKit/Source/WebKit/chromium/public/WebBindings.h"
@@ -290,9 +289,9 @@
webkit::npapi::WebPluginDelegateImpl::
PLUGIN_QUIRK_BLOCK_NONSTANDARD_GETURL_REQUESTS) {
GURL request_url(url);
- if (!request_url.SchemeIs(chrome::kHttpScheme) &&
- !request_url.SchemeIs(chrome::kHttpsScheme) &&
- !request_url.SchemeIs(chrome::kFtpScheme)) {
+ if (!request_url.SchemeIs("http") &&
+ !request_url.SchemeIs("https") &&
+ !request_url.SchemeIs("ftp")) {
Avi (use Gerrit) 2011/03/15 19:50:28 :( Can we please move the constants too?
jam 2011/03/15 20:30:06 I searched the code to see what modules below chro
return;
}
}
@@ -628,7 +627,7 @@
#endif
void WebPluginProxy::OnPaint(const gfx::Rect& damaged_rect) {
- child_process_logging::SetActiveURL(page_url_);
+ content::GetContentClient()->SetActiveURL(page_url_);
Paint(damaged_rect);
Send(new PluginHostMsg_InvalidateRect(route_id_, damaged_rect));
« no previous file with comments | « chrome/plugin/webplugin_delegate_stub.cc ('k') | content/common/plugin_carbon_interpose_constants_mac.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698