Get rid of some more dependencies on chrome\common from plugin, in preparatio...

Get rid of some more dependencies on chrome\common from plugin, in preparation for moving the plugin directory to content.

TBR=avi

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=78278

[Avi (use Gerrit), 2011-03-15 19:50:28]

Not so hot.

http://codereview.chromium.org/6677053/diff/1/chrome/plugin/webplugin_proxy.cc
File chrome/plugin/webplugin_proxy.cc (right):

http://codereview.chromium.org/6677053/diff/1/chrome/plugin/webplugin_proxy.c...
chrome/plugin/webplugin_proxy.cc:294: !request_url.SchemeIs("ftp")) {
:(

Can we please move the constants too?

[jam, 2011-03-15 20:30:06]

http://codereview.chromium.org/6677053/diff/1/chrome/plugin/webplugin_proxy.cc
File chrome/plugin/webplugin_proxy.cc (right):

http://codereview.chromium.org/6677053/diff/1/chrome/plugin/webplugin_proxy.c...
chrome/plugin/webplugin_proxy.cc:294: !request_url.SchemeIs("ftp")) {
On 2011/03/15 19:50:28, Avi wrote:
> :(
> 
> Can we please move the constants too?

I searched the code to see what modules below chrome use, and all (i.e. even
net) hardcoded them.

[Avi (use Gerrit), 2011-03-15 20:37:45]

Double-plus ungood. We should be using constants...

sigh. rubber stamp LGTM

[jam, 2011-03-15 20:41:22]

If it's any consolation, I'm pretty sure that a lot of
chrome\common\url-constants.h will move to content when we take out the chrome
dependencies from content\browser.

On 2011/03/15 20:37:45, Avi wrote:
> Double-plus ungood. We should be using constants...
> 
> sigh. rubber stamp LGTM

[Avi (use Gerrit), 2011-03-15 20:42:19]

That helps. Then we have to go back and plug the constants back in.

[jam, 2011-03-15 22:08:25]

On 2011/03/15 20:42:19, Avi wrote:
> That helps. Then we have to go back and plug the constants back in.

I have it on my list of TODOs

[Avi (use Gerrit), 2011-03-15 22:23:10]

Great to hear.