Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 6677044: Use a class field instead of global FLAG_debug_code in assember and (Closed)

Created:
9 years, 9 months ago by Vitaly Repeshko
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Use a class field instead of global FLAG_debug_code in assember and macro assembler. This way we can avoid changing the global flag value. Committed: http://code.google.com/p/v8/source/detail?r=7178

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -77 lines) Patch
M src/arm/assembler-arm.h View 3 chunks +6 lines, -0 lines 0 comments Download
M src/arm/assembler-arm.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M src/arm/macro-assembler-arm.cc View 21 chunks +22 lines, -22 lines 0 comments Download
M src/deoptimizer.cc View 2 chunks +1 line, -3 lines 0 comments Download
M src/ia32/assembler-ia32.h View 3 chunks +7 lines, -0 lines 0 comments Download
M src/ia32/assembler-ia32.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 19 chunks +20 lines, -20 lines 0 comments Download
M src/x64/assembler-x64.h View 3 chunks +9 lines, -0 lines 0 comments Download
M src/x64/assembler-x64.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 25 chunks +26 lines, -26 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Vitaly Repeshko
9 years, 9 months ago (2011-03-15 13:42:26 UTC) #1
Mads Ager (chromium)
9 years, 9 months ago (2011-03-15 14:15:15 UTC) #2
LGTM!

Powered by Google App Engine
This is Rietveld 408576698