Issue 6677042: Decouple TabRestoreService from Browser

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6677042: Decouple TabRestoreService from Browser (Closed)

Created:
9 years, 9 months ago by bulach

Modified:
9 years, 7 months ago

Reviewers:

CC:
chromium-reviews, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Decouple TabRestoreService from Browser Introduce a delegate interface to decouple TabRestoreService from Browser/BrowserList. Also clean up dependency on TabStripModel in the process. (on behalf of torne@google.com, http://codereview.chromium.org/6660028/) BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=78218

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+371 lines, -119 lines)			Patch
M	chrome/browser/sessions/tab_restore_service.h	View		7 chunks	+22 lines, -21 lines	0 comments	Download
M	chrome/browser/sessions/tab_restore_service.cc	View		12 chunks	+75 lines, -77 lines	0 comments	Download
M	chrome/browser/sessions/tab_restore_service_browsertest.cc	View		11 chunks	+11 lines, -11 lines	0 comments	Download
A	chrome/browser/sessions/tab_restore_service_delegate.h	View		1 chunk	+72 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/browser.h	View		4 chunks	+8 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/browser.cc	View		7 chunks	+15 lines, -6 lines	0 comments	Download
A	chrome/browser/ui/browser_tab_restore_service_delegate.h	View		1 chunk	+59 lines, -0 lines	0 comments	Download
A	chrome/browser/ui/browser_tab_restore_service_delegate.cc	View	1	1 chunk	+99 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/cocoa/history_menu_cocoa_controller.mm	View	1	2 chunks	+3 lines, -1 line	0 comments	Download
M	chrome/browser/ui/webui/new_tab_ui.cc	View		2 chunks	+5 lines, -3 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View		1 chunk	+2 lines, -0 lines	0 comments	Download