Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Issue 6677036: Fast path for strict closure creation. (Closed)

Created:
9 years, 9 months ago by Martin Maly
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Fast path for strict closure creation. BUG=http://code.google.com/p/v8/issues/detail?id=1249 TEST=strict-mode.js

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -39 lines) Patch
M src/arm/code-stubs-arm.cc View 1 chunk +5 lines, -1 line 0 comments Download
M src/arm/codegen-arm.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/arm/full-codegen-arm.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/bootstrapper.cc View 1 chunk +2 lines, -2 lines 2 comments Download
M src/code-stubs.h View 1 chunk +6 lines, -1 line 0 comments Download
M src/contexts.h View 2 chunks +6 lines, -6 lines 1 comment Download
M src/ia32/code-stubs-ia32.cc View 1 chunk +5 lines, -1 line 1 comment Download
M src/ia32/codegen-ia32.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 1 chunk +5 lines, -1 line 0 comments Download
M src/x64/codegen-x64.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Martin Maly
Implementing FastNewClosureStub for strict mode functions. The FastNewClosureStub is parametrized via strict/non-strict mode and during ...
9 years, 9 months ago (2011-03-15 03:08:57 UTC) #1
Mads Ager (chromium)
9 years, 9 months ago (2011-03-15 08:49:54 UTC) #2
LGTM

http://codereview.chromium.org/6677036/diff/1/src/bootstrapper.cc
File src/bootstrapper.cc (right):

http://codereview.chromium.org/6677036/diff/1/src/bootstrapper.cc#newcode568
src/bootstrapper.cc:568: 
On 2011/03/15 03:08:57, Martin Maly wrote:
> For some reason this felt cleaner, to freeze first and then install...

I agree. :)

http://codereview.chromium.org/6677036/diff/1/src/ia32/code-stubs-ia32.cc
File src/ia32/code-stubs-ia32.cc (right):

http://codereview.chromium.org/6677036/diff/1/src/ia32/code-stubs-ia32.cc#new...
src/ia32/code-stubs-ia32.cc:73: ? Context::FUNCTION_MAP_STRICT_INDEX
This is part of another change but I think I would prefer the name
STRICT_FUNCTION_MAP_INDEX or even (but that is very long)
STRICT_MODE_FUNCTION_MAP_INDEX. Similarly for the other strict mode variants of
maps.

Powered by Google App Engine
This is Rietveld 408576698