Issue 6677033: Revert "Add --kloadaddr option to utilities"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6677033: Revert "Add --kloadaddr option to utilities" (Closed)

Created:
9 years, 9 months ago by marcheu

Modified:
9 years, 7 months ago

Reviewers:
sjg, Che-Liang Chiou

CC:
chromium-os-reviews_chromium.org, Randall Spangler, gauravsh, Luigi Semenzato, Bill Richardson

Base URL:
ssh://git@gitrw.chromium.org:9222/vboot_reference.git@master

Visibility:
Public.

Description

Revert "Add --kloadaddr option to utilities" This reverts commit 1a0975f5f477abe7425e2b7ade655d73138e5c64. This fixes chromeos-install on x86-mario with a kernel-next profile. BUG=None TEST=Build an x86-mario image with kernel-next, check that /usr/sbin/chromeos-install works. Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=bc7a84d

Patch Set 1 #

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -94 lines)			Patch
	M	utility/dump_kernel_config.c	View		6 chunks	+7 lines, -53 lines	0 comments	Download
	M	utility/vbutil_kernel.c	View		18 chunks	+18 lines, -41 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

sjg

9 years, 9 months ago (2011-03-15 16:59:29 UTC) #2

LGTM

I did not hear from Che-Liang overnight so we should revert this and put it back
into his court.

Expand Messages | Collapse Messages