Issue 6677030: Fixes crash if instant is enabled and you block JS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6677030: Fixes crash if instant is enabled and you block JS. (Closed)

Created:
9 years, 9 months ago by sky

Modified:
9 years, 7 months ago

Reviewers:
tonyg, tonyg_google

CC:
chromium-reviews, pam+watch_chromium.org, Aaron Boodman, Erik does not do reviews, darin-cc_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Fixes crash if instant is enabled and you block JS. BUG=76077 TEST=see bug R=tonyg@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=78277

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -2 lines)			Patch
M	chrome/browser/instant/instant_browsertest.cc	View	1	2 chunks	+15 lines, -0 lines	0 comments	Download
M	chrome/browser/instant/instant_loader.cc	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download
M	chrome/renderer/searchbox_extension.cc	View		2 chunks	+5 lines, -2 lines	0 comments	Download
M	content/common/notification_type.h	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

tonyg_google

FIx looks good. It shouldn't be that hard to add a regression test for this ...

9 years, 9 months ago (2011-03-15 00:17:38 UTC) #2

Thanks! LGTM