Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 6677022: Code cleanup related to allowed_bad_certs.... (Closed)

Created:
9 years, 9 months ago by wtc
Modified:
9 years, 7 months ago
CC:
chromium-reviews, jamiewalch+watch_chromium.org, hclam+watch_chromium.org, cbentzel+watch_chromium.org, simonmorris+watch_chromium.org, wez+watch_chromium.org, Paweł Hajdan Jr., dmaclach+watch_chromium.org, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, darin-cc_chromium.org, ajwong+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

Code cleanup related to allowed_bad_certs. cert_status is a bitwise-OR of CERT_STATUS_xxx, not ERR_CERT_xxx. Initialize a CertAndStatus structure after checking it is needed. Fix a typo in comments. R=hclam BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=78123

Patch Set 1 #

Patch Set 2 : Fix typo in comments #

Patch Set 3 : Save file and try again #

Patch Set 4 : Include cert_status_flags.h #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -7 lines) Patch
M net/http/http_stream_factory_impl_job.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M net/socket/ssl_server_socket_unittest.cc View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
M net/socket_stream/socket_stream.cc View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M remoting/protocol/jingle_session.cc View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
wtc
9 years, 9 months ago (2011-03-14 22:17:46 UTC) #1
Alpha Left Google
LGTM. Thanks!
9 years, 9 months ago (2011-03-14 22:19:57 UTC) #2
commit-bot: I haz the power
Try job failure for 6677022-3002 on win: http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number=21103
9 years, 9 months ago (2011-03-14 22:35:46 UTC) #3
commit-bot: I haz the power
9 years, 9 months ago (2011-03-14 23:29:37 UTC) #4
Change committed as 78123

Powered by Google App Engine
This is Rietveld 408576698