Issue 6677018: autotest/factory_PreFinalCheck: add verified boot key matching test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6677018: autotest/factory_PreFinalCheck: add verified boot key matching test (Closed)

Created:
9 years, 9 months ago by Hung-Te

Modified:
9 years, 7 months ago

Reviewers:
Tammo Spalink, Nick Sanders

CC:
chromium-os-reviews_chromium.org, sosa+cc_chromium.org, seano+cc_chromium.org, ericli

Base URL:
ssh://git@gitrw.chromium.org:9222/autotest.git@master

Visibility:
Public.

Description

autotest/factory_PreFinalCheck: add verified boot key matching test Using dev_debug_vboot to verify all the keys are correct. NOTE: verifying needs to read from system flashrom, and that takes 10-20 seconds on Alex for each trial (pressing space). Before this CL, PreFinalCheck takes 1-2 seconds for each run; by applying this CL, each run needs 10+ seconds. BUG=chrome-os-partner:2634 TEST=on alex with OS in partition B signed with ssd key -> pass OS in B signed with recovery key -> fail Change-Id: I8bac210ff74fa5f2f1c6979e50b349e4da82a203 Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=54ad315

Patch Set 1 #

Patch Set 2 : simple check of flooded key-press events #

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -0 lines)			Patch
	M	client/site_tests/factory_PreFinalCheck/factory_PreFinalCheck.py	View	1	4 chunks	+18 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Hung-Te

Added a simple check to discard cached key-press events by adding one more second to ...

9 years, 9 months ago (2011-03-14 07:28:36 UTC) #3

Nick Sanders

lgtm. can you file a bug to not cache keypresses between tests, probably we shouldn't ...

9 years, 9 months ago (2011-03-15 01:50:35 UTC) #4

Hung-Te

9 years, 9 months ago (2011-03-15 02:10:44 UTC) #5

On 2011/03/15 01:50:35, Nick Sanders wrote:
> lgtm. can you file a bug to not cache keypresses between tests, probably we
> shouldn't have to track this in each test.
  I've updated http://code.google.com/p/chrome-os-partner/issues/detail?id=1622
to address that - it should be solved at the same time.

Expand Messages | Collapse Messages