Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Issue 6677017: Fix a problem where Object.getOwnPropertyDescriptor and related functions uni... (Closed)

Created:
9 years, 9 months ago by William Hesse
Modified:
9 years, 7 months ago
Reviewers:
Rico
CC:
v8-dev
Visibility:
Public.

Description

Fix a problem where Object.getOwnPropertyDescriptor and related functions unintentionally called toString on the values of an object's properties. Fixes issue 1233. Committed: http://code.google.com/p/v8/source/detail?r=7151

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -3 lines) Patch
M src/v8natives.js View 3 chunks +3 lines, -3 lines 0 comments Download
A test/mjsunit/regress/regress-1233.js View 1 2 1 chunk +47 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
William Hesse
9 years, 9 months ago (2011-03-11 10:46:06 UTC) #1
Rico
LGTM if we add a regression test.
9 years, 9 months ago (2011-03-11 10:49:09 UTC) #2
William Hesse
9 years, 9 months ago (2011-03-11 13:22:16 UTC) #3
Regression test added.

Powered by Google App Engine
This is Rietveld 408576698