Expose and augment parser enum and field name tables to bct_dump.

Expose and augment parser enum and field name tables to bct_dump.

This adds the nvbctlib id value to the field_item struct and makes
the parser tables available outside of parse.c.  This lets bct_dump
use these to pretty print a BCT in a format that the parser can
later read back in.

BUG=chromium-os:11981
TEST=Sign and boot a U-Boot image on Seaboard using:

sudo emerge -av cbootimage
USE="recovery flasher" emerge-tegra2_seaboard -av chromeos-u-boot-next
cros_write_firmware --board tegra2_seaboard --firmware /build/tegra2_seaboard/u-boot/u-boot-recovery.bin --sign

Change-Id: Ibcc8ce5c2c62cbfea8ca2850ddd8122b84c0f78f

Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=e517a4f

[robotboy, 2011-03-11 00:02:11]

Hi guys, this is the first step towards making bct_dump generate valid
cbootimage parsable config files.

Thanks,
    Anton

[Vincent Palatin, 2011-03-11 14:32:10]

LGTM, nice improvement

a few tabs and printf nits.

http://codereview.chromium.org/6677007/diff/1/bct_dump.c
File bct_dump.c (right):

http://codereview.chromium.org/6677007/diff/1/bct_dump.c#newcode96
bct_dump.c:96: int i;
it seems you are using spaces here and tabs later.

http://codereview.chromium.org/6677007/diff/1/bct_dump.c#newcode239
bct_dump.c:239: field_item const * item = device_field_table + j;
nit: the for loop can directly iterate over item, j is not used.

http://codereview.chromium.org/6677007/diff/1/bct_dump.c#newcode247
bct_dump.c:247: (int)(width - strlen(item->name)), "",
I think this is equivalent to this simpler syntax :
printf("    %-*s = 0x%08x\n", width, item->name,
        e == 0 ? data : -1);

http://codereview.chromium.org/6677007/diff/1/bct_dump.c#newcode272
bct_dump.c:272: field_item const * item = s_sdram_field_table + j;
ditto

http://codereview.chromium.org/6677007/diff/1/bct_dump.c#newcode280
bct_dump.c:280: (int)(width - strlen(item->name)), "");
ditto

[robotboy, 2011-03-11 19:28:53]

Done, thanks.

http://codereview.chromium.org/6677007/diff/1/bct_dump.c
File bct_dump.c (right):

http://codereview.chromium.org/6677007/diff/1/bct_dump.c#newcode96
bct_dump.c:96: int i;
On 2011/03/11 14:32:10, Vincent Palatin wrote:
> it seems you are using spaces here and tabs later.

This appears to be an artifact of the code review display.  These are tabs as
well.

http://codereview.chromium.org/6677007/diff/1/bct_dump.c#newcode239
bct_dump.c:239: field_item const * item = device_field_table + j;
On 2011/03/11 14:32:10, Vincent Palatin wrote:
> nit: the for loop can directly iterate over item, j is not used.

Done.

http://codereview.chromium.org/6677007/diff/1/bct_dump.c#newcode247
bct_dump.c:247: (int)(width - strlen(item->name)), "",
On 2011/03/11 14:32:10, Vincent Palatin wrote:
> I think this is equivalent to this simpler syntax :
> printf("    %-*s = 0x%08x\n", width, item->name,
>         e == 0 ? data : -1);

Done.

http://codereview.chromium.org/6677007/diff/1/bct_dump.c#newcode272
bct_dump.c:272: field_item const * item = s_sdram_field_table + j;
On 2011/03/11 14:32:10, Vincent Palatin wrote:
> ditto

Done.

http://codereview.chromium.org/6677007/diff/1/bct_dump.c#newcode280
bct_dump.c:280: (int)(width - strlen(item->name)), "");
On 2011/03/11 14:32:10, Vincent Palatin wrote:
> ditto

Done.

[robotboy, 2011-03-11 19:30:11]

Peer, are you OK with the changes I've made to the common parse.[ch] code?

Thanks,
    Anton

[pchen, 2011-03-14 06:12:02]

It's ok, LGTM.