Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1021)

Side by Side Diff: chrome/browser/prerender/prerender_manager.cc

Issue 6677005: Limit prerender by only allowing one every X ms (X currently set to 500). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Added histogram for time between requests Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/prerender/prerender_manager.h" 5 #include "chrome/browser/prerender/prerender_manager.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "base/metrics/histogram.h" 8 #include "base/metrics/histogram.h"
9 #include "base/time.h" 9 #include "base/time.h"
10 #include "base/utf_string_conversions.h" 10 #include "base/utf_string_conversions.h"
11 #include "chrome/browser/fav_icon_helper.h" 11 #include "chrome/browser/fav_icon_helper.h"
12 #include "chrome/browser/prerender/prerender_contents.h" 12 #include "chrome/browser/prerender/prerender_contents.h"
13 #include "chrome/browser/prerender/prerender_final_status.h" 13 #include "chrome/browser/prerender/prerender_final_status.h"
14 #include "chrome/common/render_messages.h" 14 #include "chrome/common/render_messages.h"
15 #include "content/browser/browser_thread.h" 15 #include "content/browser/browser_thread.h"
16 #include "content/browser/renderer_host/render_view_host.h" 16 #include "content/browser/renderer_host/render_view_host.h"
17 #include "content/browser/renderer_host/render_process_host.h" 17 #include "content/browser/renderer_host/render_process_host.h"
18 #include "content/browser/tab_contents/tab_contents.h" 18 #include "content/browser/tab_contents/tab_contents.h"
19 #include "content/browser/tab_contents/render_view_host_manager.h" 19 #include "content/browser/tab_contents/render_view_host_manager.h"
20 20
21 namespace prerender { 21 namespace prerender {
22 22
23 // static 23 // static
24 base::TimeTicks PrerenderManager::last_prefetch_seen_time_; 24 base::TimeTicks PrerenderManager::last_prefetch_seen_time_;
25 25
26 // static 26 // static
27 base::TimeTicks PrerenderManager::last_prerender_start_time_;
28
29 // static
30 bool PrerenderManager::rate_limit_enabled_ = true;
31
32 // static
27 PrerenderManager::PrerenderManagerMode PrerenderManager::mode_ = 33 PrerenderManager::PrerenderManagerMode PrerenderManager::mode_ =
28 PRERENDER_MODE_ENABLED; 34 PRERENDER_MODE_ENABLED;
29 35
30 // static 36 // static
31 PrerenderManager::PrerenderManagerMode PrerenderManager::GetMode() { 37 PrerenderManager::PrerenderManagerMode PrerenderManager::GetMode() {
32 return mode_; 38 return mode_;
33 } 39 }
34 40
35 // static 41 // static
36 void PrerenderManager::SetMode(PrerenderManagerMode mode) { 42 void PrerenderManager::SetMode(PrerenderManagerMode mode) {
(...skipping 48 matching lines...) Expand 10 before | Expand all | Expand 10 after
85 // Do not prerender if there are too many render processes, and we would 91 // Do not prerender if there are too many render processes, and we would
86 // have to use an existing one. We do not want prerendering to happen in 92 // have to use an existing one. We do not want prerendering to happen in
87 // a shared process, so that we can always reliably lower the CPU 93 // a shared process, so that we can always reliably lower the CPU
88 // priority for prerendering. 94 // priority for prerendering.
89 // TODO(tburkard): Figure out how to cancel prerendering in the opposite 95 // TODO(tburkard): Figure out how to cancel prerendering in the opposite
90 // case, when a new tab is added to a process used for prerendering. 96 // case, when a new tab is added to a process used for prerendering.
91 if (RenderProcessHost::ShouldTryToUseExistingProcessHost()) { 97 if (RenderProcessHost::ShouldTryToUseExistingProcessHost()) {
92 RecordFinalStatus(FINAL_STATUS_TOO_MANY_PROCESSES); 98 RecordFinalStatus(FINAL_STATUS_TOO_MANY_PROCESSES);
93 return false; 99 return false;
94 } 100 }
101
102 // Check if enough time has passed since the last prerender.
103 if (!DoesRateLimitAllowPrerender()) {
104 // Cancel the prerender. We could add it to the pending prerender list but
105 // this doesn't make sense as the next prerender request will be triggered
106 // by a navigation and is unlikely to be the same site.
107 RecordFinalStatus(FINAL_STATUS_RATE_LIMIT_EXCEEDED);
108 return false;
109 }
110
95 // TODO(cbentzel): Move invalid checks here instead of PrerenderContents? 111 // TODO(cbentzel): Move invalid checks here instead of PrerenderContents?
96 PrerenderContentsData data(CreatePrerenderContents(url, alias_urls, referrer), 112 PrerenderContentsData data(CreatePrerenderContents(url, alias_urls, referrer),
97 GetCurrentTime()); 113 GetCurrentTime());
98 prerender_list_.push_back(data); 114 prerender_list_.push_back(data);
115 last_prerender_start_time_ = base::TimeTicks::Now();
99 data.contents_->StartPrerendering(); 116 data.contents_->StartPrerendering();
100 while (prerender_list_.size() > max_elements_) { 117 while (prerender_list_.size() > max_elements_) {
101 data = prerender_list_.front(); 118 data = prerender_list_.front();
102 prerender_list_.pop_front(); 119 prerender_list_.pop_front();
103 data.contents_->set_final_status(FINAL_STATUS_EVICTED); 120 data.contents_->set_final_status(FINAL_STATUS_EVICTED);
104 delete data.contents_; 121 delete data.contents_;
105 } 122 }
106 StartSchedulingPeriodicCleanups(); 123 StartSchedulingPeriodicCleanups();
107 return true; 124 return true;
108 } 125 }
(...skipping 161 matching lines...) Expand 10 before | Expand all | Expand 10 after
270 // static 287 // static
271 bool PrerenderManager::ShouldRecordWindowedPPLT() { 288 bool PrerenderManager::ShouldRecordWindowedPPLT() {
272 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI)); 289 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
273 if (last_prefetch_seen_time_.is_null()) 290 if (last_prefetch_seen_time_.is_null())
274 return false; 291 return false;
275 base::TimeDelta elapsed_time = 292 base::TimeDelta elapsed_time =
276 base::TimeTicks::Now() - last_prefetch_seen_time_; 293 base::TimeTicks::Now() - last_prefetch_seen_time_;
277 return elapsed_time <= base::TimeDelta::FromSeconds(kWindowedPPLTSeconds); 294 return elapsed_time <= base::TimeDelta::FromSeconds(kWindowedPPLTSeconds);
278 } 295 }
279 296
297 // static
298 bool PrerenderManager::DoesRateLimitAllowPrerender() {
299 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
300 if (!rate_limit_enabled_)
301 return true;
302 if (last_prerender_start_time_.is_null())
303 return true;
304 base::TimeDelta elapsed_time =
305 base::TimeTicks::Now() - last_prerender_start_time_;
306 UMA_HISTOGRAM_ENUMERATION("Prerender.TimeBetweenRequests",
tburkard 2011/03/11 23:49:07 To clarify the name, maybe call it TimeBetweenPrer
307 elapsed_time.InMilliseconds(),
308 kMaxTimeBetweenPrerendersMs);
309 return elapsed_time >
310 base::TimeDelta::FromMilliseconds(kMinTimeBetweenPrerendersMs);
311 }
312
280 void PrerenderManager::StartSchedulingPeriodicCleanups() { 313 void PrerenderManager::StartSchedulingPeriodicCleanups() {
281 if (repeating_timer_.IsRunning()) 314 if (repeating_timer_.IsRunning())
282 return; 315 return;
283 repeating_timer_.Start( 316 repeating_timer_.Start(
284 base::TimeDelta::FromMilliseconds(kPeriodicCleanupIntervalMs), 317 base::TimeDelta::FromMilliseconds(kPeriodicCleanupIntervalMs),
285 this, 318 this,
286 &PrerenderManager::PeriodicCleanup); 319 &PrerenderManager::PeriodicCleanup);
287 } 320 }
288 321
289 void PrerenderManager::StopSchedulingPeriodicCleanups() { 322 void PrerenderManager::StopSchedulingPeriodicCleanups() {
(...skipping 24 matching lines...) Expand all
314 347
315 void PrerenderManager::MarkTabContentsAsNotPrerendered(TabContents* tc) { 348 void PrerenderManager::MarkTabContentsAsNotPrerendered(TabContents* tc) {
316 prerendered_tc_set_.erase(tc); 349 prerendered_tc_set_.erase(tc);
317 } 350 }
318 351
319 bool PrerenderManager::IsTabContentsPrerendered(TabContents* tc) const { 352 bool PrerenderManager::IsTabContentsPrerendered(TabContents* tc) const {
320 return prerendered_tc_set_.count(tc) > 0; 353 return prerendered_tc_set_.count(tc) > 0;
321 } 354 }
322 355
323 } // namespace prerender 356 } // namespace prerender
OLDNEW
« no previous file with comments | « chrome/browser/prerender/prerender_manager.h ('k') | chrome/browser/prerender/prerender_manager_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698