Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Side by Side Diff: chrome/browser/prerender/prerender_manager.cc

Issue 6677005: Limit prerender by only allowing one every X ms (X currently set to 500). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Adding unit test Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/prerender/prerender_manager.h" 5 #include "chrome/browser/prerender/prerender_manager.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "base/metrics/histogram.h" 8 #include "base/metrics/histogram.h"
9 #include "base/time.h" 9 #include "base/time.h"
10 #include "base/utf_string_conversions.h" 10 #include "base/utf_string_conversions.h"
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
47 struct PrerenderManager::PrerenderContentsData { 47 struct PrerenderManager::PrerenderContentsData {
48 PrerenderContents* contents_; 48 PrerenderContents* contents_;
49 base::Time start_time_; 49 base::Time start_time_;
50 PrerenderContentsData(PrerenderContents* contents, base::Time start_time) 50 PrerenderContentsData(PrerenderContents* contents, base::Time start_time)
51 : contents_(contents), 51 : contents_(contents),
52 start_time_(start_time) { 52 start_time_(start_time) {
53 } 53 }
54 }; 54 };
55 55
56 PrerenderManager::PrerenderManager(Profile* profile) 56 PrerenderManager::PrerenderManager(Profile* profile)
57 : profile_(profile), 57 : rate_limit_enabled_(true),
58 profile_(profile),
58 max_prerender_age_(base::TimeDelta::FromSeconds( 59 max_prerender_age_(base::TimeDelta::FromSeconds(
59 kDefaultMaxPrerenderAgeSeconds)), 60 kDefaultMaxPrerenderAgeSeconds)),
60 max_elements_(kDefaultMaxPrerenderElements), 61 max_elements_(kDefaultMaxPrerenderElements),
61 prerender_contents_factory_(PrerenderContents::CreateFactory()) { 62 prerender_contents_factory_(PrerenderContents::CreateFactory()),
63 last_prerender_start_time_(GetCurrentTimeTicks() -
64 base::TimeDelta::FromMilliseconds(kMinTimeBetweenPrerendersMs)) {
62 } 65 }
63 66
64 PrerenderManager::~PrerenderManager() { 67 PrerenderManager::~PrerenderManager() {
65 while (!prerender_list_.empty()) { 68 while (!prerender_list_.empty()) {
66 PrerenderContentsData data = prerender_list_.front(); 69 PrerenderContentsData data = prerender_list_.front();
67 prerender_list_.pop_front(); 70 prerender_list_.pop_front();
68 data.contents_->set_final_status(FINAL_STATUS_MANAGER_SHUTDOWN); 71 data.contents_->set_final_status(FINAL_STATUS_MANAGER_SHUTDOWN);
69 delete data.contents_; 72 delete data.contents_;
70 } 73 }
71 } 74 }
(...skipping 13 matching lines...) Expand all
85 // Do not prerender if there are too many render processes, and we would 88 // Do not prerender if there are too many render processes, and we would
86 // have to use an existing one. We do not want prerendering to happen in 89 // have to use an existing one. We do not want prerendering to happen in
87 // a shared process, so that we can always reliably lower the CPU 90 // a shared process, so that we can always reliably lower the CPU
88 // priority for prerendering. 91 // priority for prerendering.
89 // TODO(tburkard): Figure out how to cancel prerendering in the opposite 92 // TODO(tburkard): Figure out how to cancel prerendering in the opposite
90 // case, when a new tab is added to a process used for prerendering. 93 // case, when a new tab is added to a process used for prerendering.
91 if (RenderProcessHost::ShouldTryToUseExistingProcessHost()) { 94 if (RenderProcessHost::ShouldTryToUseExistingProcessHost()) {
92 RecordFinalStatus(FINAL_STATUS_TOO_MANY_PROCESSES); 95 RecordFinalStatus(FINAL_STATUS_TOO_MANY_PROCESSES);
93 return false; 96 return false;
94 } 97 }
98
99 // Check if enough time has passed since the last prerender.
100 if (!DoesRateLimitAllowPrerender()) {
101 // Cancel the prerender. We could add it to the pending prerender list but
102 // this doesn't make sense as the next prerender request will be triggered
103 // by a navigation and is unlikely to be the same site.
104 RecordFinalStatus(FINAL_STATUS_RATE_LIMIT_EXCEEDED);
105 return false;
106 }
107
95 // TODO(cbentzel): Move invalid checks here instead of PrerenderContents? 108 // TODO(cbentzel): Move invalid checks here instead of PrerenderContents?
96 PrerenderContentsData data(CreatePrerenderContents(url, alias_urls, referrer), 109 PrerenderContentsData data(CreatePrerenderContents(url, alias_urls, referrer),
97 GetCurrentTime()); 110 GetCurrentTime());
98 prerender_list_.push_back(data); 111 prerender_list_.push_back(data);
112 last_prerender_start_time_ = GetCurrentTimeTicks();
99 data.contents_->StartPrerendering(); 113 data.contents_->StartPrerendering();
100 while (prerender_list_.size() > max_elements_) { 114 while (prerender_list_.size() > max_elements_) {
101 data = prerender_list_.front(); 115 data = prerender_list_.front();
102 prerender_list_.pop_front(); 116 prerender_list_.pop_front();
103 data.contents_->set_final_status(FINAL_STATUS_EVICTED); 117 data.contents_->set_final_status(FINAL_STATUS_EVICTED);
104 delete data.contents_; 118 delete data.contents_;
105 } 119 }
106 StartSchedulingPeriodicCleanups(); 120 StartSchedulingPeriodicCleanups();
107 return true; 121 return true;
108 } 122 }
(...skipping 27 matching lines...) Expand all
136 return NULL; 150 return NULL;
137 } 151 }
138 152
139 bool PrerenderManager::MaybeUsePreloadedPage(TabContents* tc, const GURL& url) { 153 bool PrerenderManager::MaybeUsePreloadedPage(TabContents* tc, const GURL& url) {
140 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI)); 154 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
141 scoped_ptr<PrerenderContents> pc(GetEntry(url)); 155 scoped_ptr<PrerenderContents> pc(GetEntry(url));
142 if (pc.get() == NULL) 156 if (pc.get() == NULL)
143 return false; 157 return false;
144 158
145 if (!pc->load_start_time().is_null()) 159 if (!pc->load_start_time().is_null())
146 RecordTimeUntilUsed(base::TimeTicks::Now() - pc->load_start_time()); 160 RecordTimeUntilUsed(GetCurrentTimeTicks() - pc->load_start_time());
147 pc->set_final_status(FINAL_STATUS_USED); 161 pc->set_final_status(FINAL_STATUS_USED);
148 162
149 RenderViewHost* rvh = pc->render_view_host(); 163 RenderViewHost* rvh = pc->render_view_host();
150 // RenderViewHosts in PrerenderContents start out hidden. 164 // RenderViewHosts in PrerenderContents start out hidden.
151 // Since we are actually using it now, restore it. 165 // Since we are actually using it now, restore it.
152 rvh->WasRestored(); 166 rvh->WasRestored();
153 pc->set_render_view_host(NULL); 167 pc->set_render_view_host(NULL);
154 rvh->Send(new ViewMsg_DisplayPrerenderedPage(rvh->routing_id())); 168 rvh->Send(new ViewMsg_DisplayPrerenderedPage(rvh->routing_id()));
155 tc->SwapInRenderViewHost(rvh); 169 tc->SwapInRenderViewHost(rvh);
156 MarkTabContentsAsPrerendered(tc); 170 MarkTabContentsAsPrerendered(tc);
(...skipping 26 matching lines...) Expand all
183 break; 197 break;
184 } 198 }
185 } 199 }
186 DeleteOldEntries(); 200 DeleteOldEntries();
187 } 201 }
188 202
189 base::Time PrerenderManager::GetCurrentTime() const { 203 base::Time PrerenderManager::GetCurrentTime() const {
190 return base::Time::Now(); 204 return base::Time::Now();
191 } 205 }
192 206
207 base::TimeTicks PrerenderManager::GetCurrentTimeTicks() const {
208 return base::TimeTicks::Now();
209 }
210
193 bool PrerenderManager::IsPrerenderElementFresh(const base::Time start) const { 211 bool PrerenderManager::IsPrerenderElementFresh(const base::Time start) const {
194 base::Time now = GetCurrentTime(); 212 base::Time now = GetCurrentTime();
195 return (now - start < max_prerender_age_); 213 return (now - start < max_prerender_age_);
196 } 214 }
197 215
198 PrerenderContents* PrerenderManager::CreatePrerenderContents( 216 PrerenderContents* PrerenderManager::CreatePrerenderContents(
199 const GURL& url, 217 const GURL& url,
200 const std::vector<GURL>& alias_urls, 218 const std::vector<GURL>& alias_urls,
201 const GURL& referrer) { 219 const GURL& referrer) {
202 return prerender_contents_factory_->CreatePrerenderContents( 220 return prerender_contents_factory_->CreatePrerenderContents(
(...skipping 67 matching lines...) Expand 10 before | Expand all | Expand 10 after
270 // static 288 // static
271 bool PrerenderManager::ShouldRecordWindowedPPLT() { 289 bool PrerenderManager::ShouldRecordWindowedPPLT() {
272 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI)); 290 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
273 if (last_prefetch_seen_time_.is_null()) 291 if (last_prefetch_seen_time_.is_null())
274 return false; 292 return false;
275 base::TimeDelta elapsed_time = 293 base::TimeDelta elapsed_time =
276 base::TimeTicks::Now() - last_prefetch_seen_time_; 294 base::TimeTicks::Now() - last_prefetch_seen_time_;
277 return elapsed_time <= base::TimeDelta::FromSeconds(kWindowedPPLTSeconds); 295 return elapsed_time <= base::TimeDelta::FromSeconds(kWindowedPPLTSeconds);
278 } 296 }
279 297
298 bool PrerenderManager::DoesRateLimitAllowPrerender() const {
299 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
300 base::TimeDelta elapsed_time =
301 GetCurrentTimeTicks() - last_prerender_start_time_;
302 UMA_HISTOGRAM_TIMES("Prerender.TimeBetweenPrerenderRequests",
303 elapsed_time);
304 if (!rate_limit_enabled_)
305 return true;
306 return elapsed_time >
307 base::TimeDelta::FromMilliseconds(kMinTimeBetweenPrerendersMs);
308 }
309
280 void PrerenderManager::StartSchedulingPeriodicCleanups() { 310 void PrerenderManager::StartSchedulingPeriodicCleanups() {
281 if (repeating_timer_.IsRunning()) 311 if (repeating_timer_.IsRunning())
282 return; 312 return;
283 repeating_timer_.Start( 313 repeating_timer_.Start(
284 base::TimeDelta::FromMilliseconds(kPeriodicCleanupIntervalMs), 314 base::TimeDelta::FromMilliseconds(kPeriodicCleanupIntervalMs),
285 this, 315 this,
286 &PrerenderManager::PeriodicCleanup); 316 &PrerenderManager::PeriodicCleanup);
287 } 317 }
288 318
289 void PrerenderManager::StopSchedulingPeriodicCleanups() { 319 void PrerenderManager::StopSchedulingPeriodicCleanups() {
(...skipping 24 matching lines...) Expand all
314 344
315 void PrerenderManager::MarkTabContentsAsNotPrerendered(TabContents* tc) { 345 void PrerenderManager::MarkTabContentsAsNotPrerendered(TabContents* tc) {
316 prerendered_tc_set_.erase(tc); 346 prerendered_tc_set_.erase(tc);
317 } 347 }
318 348
319 bool PrerenderManager::IsTabContentsPrerendered(TabContents* tc) const { 349 bool PrerenderManager::IsTabContentsPrerendered(TabContents* tc) const {
320 return prerendered_tc_set_.count(tc) > 0; 350 return prerendered_tc_set_.count(tc) > 0;
321 } 351 }
322 352
323 } // namespace prerender 353 } // namespace prerender
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698