Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Unified Diff: chrome_frame/urlmon_url_request.cc

Issue 6677004: Fix the flakiness with download requests routed by ChromeFrame to the host br... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome_frame/chrome_frame_activex_base.h ('k') | chrome_frame/utils.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome_frame/urlmon_url_request.cc
===================================================================
--- chrome_frame/urlmon_url_request.cc (revision 77487)
+++ chrome_frame/urlmon_url_request.cc (working copy)
@@ -1073,18 +1073,15 @@
IBindCtx* bind_ctx,
IStream* post_data,
const char* request_headers) {
- DownloadInHostParams download_params;
- download_params.bind_ctx = bind_ctx;
- download_params.moniker = moniker;
- download_params.post_data = post_data;
+ DownloadInHostParams* download_params = new DownloadInHostParams;
+ download_params->bind_ctx = bind_ctx;
+ download_params->moniker = moniker;
+ download_params->post_data = post_data;
if (request_headers) {
- download_params.request_headers = request_headers;
+ download_params->request_headers = request_headers;
}
- // We use SendMessage and not PostMessage to make sure that if the
- // notification window does not handle the message we won't leak
- // the moniker.
- ::SendMessage(notification_window_, WM_DOWNLOAD_IN_HOST,
- reinterpret_cast<WPARAM>(&download_params), 0);
+ ::PostMessage(notification_window_, WM_DOWNLOAD_IN_HOST,
+ reinterpret_cast<WPARAM>(download_params), 0);
}
void UrlmonUrlRequestManager::GetCookiesForUrl(const GURL& url, int cookie_id) {
« no previous file with comments | « chrome_frame/chrome_frame_activex_base.h ('k') | chrome_frame/utils.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698