Issue 6676115: Migrating common checks to a location that affects all chromium projects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6676115: Migrating common checks to a location that affects all chromium projects. (Closed)

Created:
9 years, 9 months ago by bradn

Modified:
9 years, 7 months ago

Reviewers:
Dirk Pranke, Erik does not do reviews, M-A Ruel

CC:
chromium-reviews, robertm

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Migrating common checks to a location that affects all chromium projects. BUG=None TEST=None R=erikkay@chromium.org,dpranke@chromium.org,maruel@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=79515

Patch Set 2 : '' #

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -93 lines)			Patch
	M	PRESUBMIT.py	View	1	4 chunks	+9 lines, -93 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

M-A Ruel

lgtm with nit http://codereview.chromium.org/6676115/diff/1/PRESUBMIT.py File PRESUBMIT.py (right): http://codereview.chromium.org/6676115/diff/1/PRESUBMIT.py#newcode25 PRESUBMIT.py:25: lambda x: input_api.FilterSourceFile(x)): for f in ...

9 years, 9 months ago (2011-03-24 17:18:57 UTC) #3

bradn

http://codereview.chromium.org/6676115/diff/1/PRESUBMIT.py File PRESUBMIT.py (right): http://codereview.chromium.org/6676115/diff/1/PRESUBMIT.py#newcode25 PRESUBMIT.py:25: lambda x: input_api.FilterSourceFile(x)): On 2011/03/24 17:18:58, Marc-Antoine Ruel wrote: ...

9 years, 9 months ago (2011-03-24 17:30:22 UTC) #4

LGTM.

Expand Messages | Collapse Messages

Issue 6676115: Migrating common checks to a location that affects all chromium projects. (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Messages