Issue 6676107: Move preinst_bsdflags and postinst_bsdflags from shell to Python.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6676107: Move preinst_bsdflags and postinst_bsdflags from shell to Python. (Closed)

Created:
9 years, 9 months ago by davidjames

Modified:
9 years, 4 months ago

Reviewers:
zmedico

CC:
chromium-os-reviews_chromium.org

Visibility:
Public.

Description

Move preinst_bsdflags and postinst_bsdflags from shell to Python. Moving these commands from shell to Python helps avoid an unnecessary call to misc-functions.sh for the postinst_bsdflags. This improves performance. BUG=none TEST=Run emerge-x86-generic -eg --jobs=16 libchrome Change-Id: I0c2af50b4d2f7644cabac84fde7fe4d682010c69 R=zmedico@gmail.com

Patch Set 1 #

Patch Set 2 : Rebase against upstream master #

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -15 lines)			Patch
	M	pym/_emerge/EbuildPhase.py	View	1	2 chunks	+6 lines, -1 line	0 comments	Download
	M	pym/portage/package/ebuild/doebuild.py	View	1	3 chunks	+23 lines, -14 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

zmedico

9 years, 8 months ago (2011-04-28 21:36:20 UTC) #2

I've merged this upstream:

http://git.overlays.gentoo.org/gitweb/?p=proj/portage.git;a=commit;h=f86b547f...

There's a bug fix here:

http://git.overlays.gentoo.org/gitweb/?p=proj/portage.git;a=commit;h=a7971b43...

Expand Messages | Collapse Messages