Issue 6676101: Add P2PTransport interface in webkit_glue.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6676101: Add P2PTransport interface in webkit_glue. (Closed)

Created:
9 years, 9 months ago by Sergey Ulanov

Modified:
9 years, 7 months ago

Reviewers:
brettw, mallinath

CC:
chromium-reviews, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Add P2PTransport interface in webkit_glue. The new interface will be implemented by the renderer, and will provide P2P transport for Pepper and P2P JavaScript APIs. TEST=None BUG=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=79520

Patch Set 1 #

Patch Set 2 : - #

Total comments: 1

Patch Set 3 : more comments #

Total comments: 1

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+52 lines, -0 lines)			Patch
	A	webkit/glue/p2p_transport.h	View	1 2	1 chunk	+51 lines, -0 lines	1 comment	Download
	M	webkit/glue/webkit_glue.gypi	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

brettw

LGTM http://codereview.chromium.org/6676101/diff/3001/webkit/glue/p2p_transport.h File webkit/glue/p2p_transport.h (right): http://codereview.chromium.org/6676101/diff/3001/webkit/glue/p2p_transport.h#newcode32 webkit/glue/p2p_transport.h:32: virtual void OnMessageReceived(const char* data, size_t data_size) = ...

9 years, 9 months ago (2011-03-26 20:03:59 UTC) #2

mallinath

9 years, 9 months ago (2011-03-29 22:41:44 UTC) #3

LGTM

http://codereview.chromium.org/6676101/diff/6001/webkit/glue/p2p_transport.h
File webkit/glue/p2p_transport.h (right):

http://codereview.chromium.org/6676101/diff/6001/webkit/glue/p2p_transport.h#...
webkit/glue/p2p_transport.h:26: virtual void OnCandidateReady(const std::string&
address) = 0;
We might need some additional parameter to this function or new callback which
will signal end of candidate discovery

Expand Messages | Collapse Messages