Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issue 6676099: When we process the tickler message in our windows message pump, we should not dispatch (Closed)

Created:
9 years, 9 months ago by ananta
Modified:
9 years, 6 months ago
CC:
chromium-reviews, brettw-cc_chromium.org
Visibility:
Public.

Description

When we process the tickler message in our windows message pump, we should not dispatch all window messages specifically if we are in the context of a Windows modal loop, i.e. a Windows API like TrackPopupMenu, etc. This is because these API's expect to handle input messages like keyboard and mouse messages by peeking them from the queue and handling them. Our message pump currently dispatches all windows messages while processing the tickler message which causes the windows modal loop to not see keyboard and mouse messages at times. Added a flag in the windows message loop which indicates if we are in the context of an os modal loop. If yes we just peek for WM_PAINT and timer and dispatch those and get out. Fixes bug http://code.google.com/p/chromium/issues/detail?id=59864 BUG=59864 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=79248

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Patch Set 7 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -1 line) Patch
M base/message_loop.h View 1 2 2 chunks +13 lines, -0 lines 0 comments Download
M base/message_loop.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M base/message_pump_win.cc View 1 2 3 4 5 6 2 chunks +13 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
ananta
9 years, 9 months ago (2011-03-23 21:55:57 UTC) #1
jar (doing other things)
9 years, 9 months ago (2011-03-23 23:03:53 UTC) #2
LGTM

Thanks!

Powered by Google App Engine
This is Rietveld 408576698