Fix for "Mouseovers follow the cursor even when there's a find bar in the way"

chrome/browser/renderer_host/render_widget_host_view_mac.mm

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <QuartzCore/QuartzCore.h>
 
 #include "chrome/browser/renderer_host/render_widget_host_view_mac.h"
 
 #include "app/surface/io_surface_support_mac.h"
 #include "base/command_line.h"
@@ skipping 1402 matching lines @@
   self = [super initWithFrame:NSZeroRect];
   if (self) {
     editCommand_helper_.reset(new RWHVMEditCommandHelper);
     editCommand_helper_->AddEditingSelectorsToClass([self class]);
 
     renderWidgetHostView_.reset(r);
     canBeKeyView_ = YES;
     takesFocusOnlyOnMouseDown_ = NO;
     closeOnDeactivate_ = NO;
     focusedPluginIdentifier_ = -1;
+    mouseEventWasIgnored_ = NO;

[Mark Mentovai, 2011/03/24 18:44:40]

Is NO really the right thing to initialize this to? I guess the find view can’t
be shown yet when the RWHVC is created.

You don’t need to initialize things to NO, NULL, 0, or nil. See
http://google-styleguide.googlecode.com/svn/trunk/objcguide.xml?showone=Initi...
. You can get rid of lines 1420 and 1421, too.

[Alexei Svitkine (slow), 2011/03/24 19:04:56]

Done.

   }
   return self;
 }
 
 - (void)setCanBeKeyView:(BOOL)can {
   canBeKeyView_ = can;
 }
 
 - (void)setTakesFocusOnlyOnMouseDown:(BOOL)b {
   takesFocusOnlyOnMouseDown_ = b;
 }
 
 - (void)setCloseOnDeactivate:(BOOL)b {
   closeOnDeactivate_ = b;
 }
 
 - (void)mouseEvent:(NSEvent*)theEvent {
+  // Use hitTest to check whether we're the frontmost view for this mouse

[Mark Mentovai, 2011/03/24 18:44:40]

s/we're/this is/

[Alexei Svitkine (slow), 2011/03/24 19:04:56]

Done.

+  // location. If this is not the frontmost view, don't handle the event
+  // here - let the frontmost view handle it.
+  NSView* contentView = [[self window] contentView];
+  if ([contentView hitTest:[theEvent locationInWindow]] != self) {
+    // If this is the first such event, send a mouse exit to the host view.
+    if (!mouseEventWasIgnored_ && renderWidgetHostView_->render_widget_host_) {
+      WebMouseEvent exitEvent =
+          WebInputEventFactory::mouseEvent(theEvent, self);
+      exitEvent.type = WebInputEvent::MouseLeave;
+      exitEvent.button = WebMouseEvent::ButtonNone;
+      renderWidgetHostView_->render_widget_host_->ForwardMouseEvent(exitEvent);
+    }
+    mouseEventWasIgnored_ = YES;
+    return;
+  }
+
+  // If the previous event was ignored as a result of the hitTest, send a mouse
+  // event to the host view.
+  if (mouseEventWasIgnored_) {
+    if (renderWidgetHostView_->render_widget_host_) {
+      WebMouseEvent enterEvent =
+          WebInputEventFactory::mouseEvent(theEvent, self);
+      enterEvent.type = WebInputEvent::MouseMove;
+      enterEvent.button = WebMouseEvent::ButtonNone;
+      renderWidgetHostView_->render_widget_host_->ForwardMouseEvent(enterEvent);
+    }
+    mouseEventWasIgnored_ = NO;
+  }
+
   // TODO(rohitrao): Probably need to handle other mouse down events here.
   if ([theEvent type] == NSLeftMouseDown && takesFocusOnlyOnMouseDown_) {
     if (renderWidgetHostView_->render_widget_host_)
       renderWidgetHostView_->render_widget_host_->OnMouseActivate();
 
     // Manually take focus after the click but before forwarding it to the
     // renderer.
     [[self window] makeFirstResponder:self];
   }
 
@@ skipping 1413 matching lines @@
   if (!string) return NO;
 
   // If the user is currently using an IME, confirm the IME input,
   // and then insert the text from the service, the same as TextEdit and Safari.
   [self confirmComposition];
   [self insertText:string];
   return YES;
 }
 
 @end