Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2108)

Issue 6676085: Update the Portuguese (Brazil) dictionary and adds a Serbian (Latin) dictionary. (Closed)

Created:
9 years, 9 months ago by Hironori Bono
Modified:
9 years, 7 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews
Visibility:
Public.

Description

Update the Portuguese (Brazil) dictionary and adds a Serbian (Latin) dictionary. This change updates the Portuguese (Brazil) dictionary with the one provided by <http://www.broffice.org/>; and added a Serbian (Latin) dictionary provided by <http://openoffice.rs/dict-sr/>;. (This change uses the language code "sh" instead of "sr-Latn" since Chrome has already used "sh" for Serbian (Latin).) BUG=53018, 57494 TEST=<http://codereview.chromium.org/6708081/> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=79099

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -1 line) Patch
M third_party/hunspell_dictionaries/README.chromium View 1 2 3 3 chunks +6 lines, -1 line 2 comments Download
A third_party/hunspell_dictionaries/README-sh.txt View 1 2 3 1 chunk +19 lines, -0 lines 0 comments Download
A third_party/hunspell_dictionaries/pt-BR-2-2.bdic View 1 2 3 Binary file 0 comments Download
M third_party/hunspell_dictionaries/pt_BR.dic View 1 2 3 Binary file 0 comments Download
A third_party/hunspell_dictionaries/sh.aff View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
A third_party/hunspell_dictionaries/sh.dic_delta View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
A third_party/hunspell_dictionaries/sh-2-2.bdic View 1 2 3 Binary file 0 comments Download

Messages

Total messages: 5 (0 generated)
Hironori Bono
Greetings, Unfortunately, I cannot upload "pt_BR.aff" or "sh.dic" to Rietveld because they are too large. ...
9 years, 9 months ago (2011-03-22 09:46:57 UTC) #1
Evan Stade
lgtm-ish http://codereview.chromium.org/6676085/diff/6006/third_party/hunspell_dictionaries/README.chromium File third_party/hunspell_dictionaries/README.chromium (right): http://codereview.chromium.org/6676085/diff/6006/third_party/hunspell_dictionaries/README.chromium#newcode97 third_party/hunspell_dictionaries/README.chromium:97: sr: Added a word. why do you mention ...
9 years, 9 months ago (2011-03-22 18:47:37 UTC) #2
Evan Stade
http://codereview.chromium.org/6676085/diff/6006/third_party/hunspell_dictionaries/README.chromium File third_party/hunspell_dictionaries/README.chromium (right): http://codereview.chromium.org/6676085/diff/6006/third_party/hunspell_dictionaries/README.chromium#newcode97 third_party/hunspell_dictionaries/README.chromium:97: sr: Added a word. On 2011/03/22 18:47:37, Evan Stade ...
9 years, 9 months ago (2011-03-22 18:50:48 UTC) #3
Evan Stade
or rather, sr is Serbian and sh is Serbo-Croatian
9 years, 9 months ago (2011-03-22 18:52:30 UTC) #4
Hironori Bono
9 years, 9 months ago (2011-03-23 03:51:06 UTC) #5
Thank you for your review.

On 2011/03/22 18:52:30, Evan Stade wrote:
> or rather, sr is Serbian and sh is Serbo-Croatian

Yes, sr is Serbian and sh is Serbo-Croatian. I have added "sr" to this list just
because I forgot updating the list when I added the Serbian (Cyrillic)
dictionary. (I should have described it in the message. Sorry.)

Regards,

Hironori Bono

Powered by Google App Engine
This is Rietveld 408576698