Enable OWNERS file enforcement in depot_tools

Enable OWNERS file enforcement in depot_tools

R=chase@chromium.org,maruel@chromium.org
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=78632

[Dirk Pranke, 2011-03-17 18:40:58]

sigh.

[chase, 2011-03-17 18:46:21]

lgtm

[chase, 2011-03-17 18:47:38]

If this could cause a disruption, can you land off-peak hours to give a chance
to roll back without causing a wider outage?  Thanks.

[Dirk Pranke, 2011-03-17 18:51:33]

This'll only affect changes to depot_tools itself, which means it'll
probably just bug us. That okay with you?

I'd rather land as many things on-hours and back them out quickly if
necessary than risk having people be affected by them when I'm not
around to support.

-- Dirk

On Thu, Mar 17, 2011 at 11:47 AM,  <chase@chromium.org> wrote:
> If this could cause a disruption, can you land off-peak hours to give a
> chance
> to roll back without causing a wider outage?  Thanks.
>
> http://codereview.chromium.org/6676058/
>

[chase, 2011-03-17 19:00:19]

On 2011/03/17 18:51:33, dpranke wrote:
> This'll only affect changes to depot_tools itself, which means it'll
> probably just bug us. That okay with you?

Oh sure, depot_tools is fine.  Thanks for pointing that out. :)

> I'd rather land as many things on-hours and back them out quickly if
> necessary than risk having people be affected by them when I'm not
> around to support.

Yeah, I agree, this is a trade-off we commonly face.  And I agree landing off
peak raises its own challenges.  I'm thinking the best off peak time to land
something like this for trunk/src/ is between 8:00-10:00 Pacific.  Not as many
are online in MTV and it's lunch-time on the east coast.  If there's a problem,
people will notice as they come online, but the slow ramp-up of people coming
online lets the big problems get reported right away and still not affect too
many developers.

Again, disregard that for trunk/tools/depot_tools/, though.  Landing this will
not be a big deal since people working there tend to have their fire suits on.

[Dirk Pranke, 2011-03-17 19:07:51]

Good advice, thanks.

On Thu, Mar 17, 2011 at 12:00 PM,  <chase@chromium.org> wrote:
> On 2011/03/17 18:51:33, dpranke wrote:
>>
>> This'll only affect changes to depot_tools itself, which means it'll
>> probably just bug us. That okay with you?
>
> Oh sure, depot_tools is fine.  Thanks for pointing that out. :)
>
>> I'd rather land as many things on-hours and back them out quickly if
>> necessary than risk having people be affected by them when I'm not
>> around to support.
>
> Yeah, I agree, this is a trade-off we commonly face.  And I agree landing
> off
> peak raises its own challenges.  I'm thinking the best off peak time to land
> something like this for trunk/src/ is between 8:00-10:00 Pacific.  Not as
> many
> are online in MTV and it's lunch-time on the east coast.  If there's a
> problem,
> people will notice as they come online, but the slow ramp-up of people
> coming
> online lets the big problems get reported right away and still not affect
> too
> many developers.
>
> Again, disregard that for trunk/tools/depot_tools/, though.  Landing this
> will
> not be a big deal since people working there tend to have their fire suits
> on.
>
> http://codereview.chromium.org/6676058/
>