Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Unified Diff: webkit/plugins/ppapi/ppb_audio_impl.cc

Issue 6676045: Implement a proxy for URL util. Some of the implementation that doesn't need ... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webkit/plugins/ppapi/ppb_audio_impl.h ('k') | webkit/plugins/ppapi/ppb_url_util_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/plugins/ppapi/ppb_audio_impl.cc
===================================================================
--- webkit/plugins/ppapi/ppb_audio_impl.cc (revision 78515)
+++ webkit/plugins/ppapi/ppb_audio_impl.cc (working copy)
@@ -220,7 +220,11 @@
}
PPB_Audio_Impl::~PPB_Audio_Impl() {
- // Calling ShutDown() makes sure StreamCreated cannot be called anymore.
+ // Calling ShutDown() makes sure StreamCreated cannot be called anymore and
+ // releases the audio data associated with the pointer. Note however, that
+ // until ShutDown returns, StreamCreated may still be called. This will be
+ // OK since we'll just immediately clean up the data it stored later in this
+ // destructor.
if (audio_) {
audio_->ShutDown();
audio_ = NULL;
« no previous file with comments | « webkit/plugins/ppapi/ppb_audio_impl.h ('k') | webkit/plugins/ppapi/ppb_url_util_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698