Implement a proxy for URL util. Some of the implementation that doesn't need ...

Implement a proxy for URL util. Some of the implementation that doesn't need to
be proxied moved into a new shared_impl file, which required a decent amount of
glue to make it callable from both the implementation and the proxy. The payoff
here is only marginal since the code is fairly simple, but I decided this is
still better than duplication.

This also includes some comments from my audio patch that I forgot in that CL.

BUG=none
TEST=ppapi_tests run out of process pass
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=78646

[yzshen1, 2011-03-16 21:19:22]

http://codereview.chromium.org/6676045/diff/8001/ppapi/proxy/ppb_url_util_pro...
File ppapi/proxy/ppb_url_util_proxy.cc (right):

http://codereview.chromium.org/6676045/diff/8001/ppapi/proxy/ppb_url_util_pro...
ppapi/proxy/ppb_url_util_proxy.cc:13: #include "ppapi/proxy/serialized_var.h"
It has been included by ppb_url_util_proxy.h.

http://codereview.chromium.org/6676045/diff/8001/ppapi/proxy/ppb_url_util_pro...
ppapi/proxy/ppb_url_util_proxy.cc:116: return PP_MakeNull();
Is it intended that line 74 & 116 return different values?

http://codereview.chromium.org/6676045/diff/8001/ppapi/proxy/ppb_url_util_pro...
File ppapi/proxy/ppb_url_util_proxy.h (right):

http://codereview.chromium.org/6676045/diff/8001/ppapi/proxy/ppb_url_util_pro...
ppapi/proxy/ppb_url_util_proxy.h:17: class SerializedVarReturnValue;
We don't need this because serialized_var.h has been included.

http://codereview.chromium.org/6676045/diff/8001/ppapi/shared_impl/url_util_i...
File ppapi/shared_impl/url_util_impl.cc (right):

http://codereview.chromium.org/6676045/diff/8001/ppapi/shared_impl/url_util_i...
ppapi/shared_impl/url_util_impl.cc:40: PP_Var relative,
Please use the same name as the one in the .h file.

http://codereview.chromium.org/6676045/diff/8001/ppapi/shared_impl/url_util_i...
ppapi/shared_impl/url_util_impl.cc:73: void URLUtilImpl::ConvertComponents(const
url_parse::Parsed& input,
It seems this one is not used by anyone other than URLUtilImpl itself. If that
is true, we could consider putting it in the anonymous namespace.

http://codereview.chromium.org/6676045/diff/8001/ppapi/shared_impl/url_util_i...
File ppapi/shared_impl/url_util_impl.h (right):

http://codereview.chromium.org/6676045/diff/8001/ppapi/shared_impl/url_util_i...
ppapi/shared_impl/url_util_impl.h:21: // Contains the implementation of URLUtil
that is shared between the proxy and
[minor]
It seems to me URLUtil is not an existing class or widely-used phrase. Might be
better to change to URL utilities or things like that.

http://codereview.chromium.org/6676045/diff/8001/ppapi/shared_impl/url_util_i...
ppapi/shared_impl/url_util_impl.h:28: // the the string creation function so can
be used independently of this.
the -> to, please.

[brettw, 2011-03-17 16:39:50]

Thanks, I addressed all the comments, new snap up.

[yzshen1, 2011-03-17 16:55:18]

LGTM

Thanks!