Improve ARM-Simulator.

Improve ARM-Simulator.

This patch
- removes the unimplemented code crash when rendering invalid/unknown instructions and prints "unknown" instead.
- prints the beginning of the constant pool marker.
- adds "da" as a shortcut for "disasm".
- print hexadecimal representation of double and single registers. This makes it easier to debug move/conversion code that uses temporary int32 values in floating point registers.
- annotates the stack with short prints of the values (HeapObjects and smis),
- makes disasm take an address or a register as second argument without a third argument, which defaults to printing ten instructions.

[Søren Thygesen Gjesse, 2011-03-16 22:28:42]

LGTM

http://codereview.chromium.org/6676042/diff/1/src/arm/disasm-arm.cc
File src/arm/disasm-arm.cc (right):

http://codereview.chromium.org/6676042/diff/1/src/arm/disasm-arm.cc#newcode1326
src/arm/disasm-arm.cc:1326: Format(instr, "constant pool begin");
Maybe print the constant pool size which is encoded in the "instruction".

http://codereview.chromium.org/6676042/diff/1/src/arm/simulator-arm.cc
File src/arm/simulator-arm.cc (right):

http://codereview.chromium.org/6676042/diff/1/src/arm/simulator-arm.cc#newcod...
src/arm/simulator-arm.cc:409: } else if (strcmp(cmd, "disasm") == 0 ||
strcmp(cmd, "da")) {
Maybe di instead of da?

[Karl Klose, 2011-03-17 10:10:07]

I also updated the help text to include the changes to disasm.

http://codereview.chromium.org/6676042/diff/1/src/arm/disasm-arm.cc
File src/arm/disasm-arm.cc (right):

http://codereview.chromium.org/6676042/diff/1/src/arm/disasm-arm.cc#newcode1326
src/arm/disasm-arm.cc:1326: Format(instr, "constant pool begin");
On 2011/03/16 22:28:42, Søren Gjesse wrote:
> Maybe print the constant pool size which is encoded in the "instruction".

Done.

http://codereview.chromium.org/6676042/diff/1/src/arm/simulator-arm.cc
File src/arm/simulator-arm.cc (right):

http://codereview.chromium.org/6676042/diff/1/src/arm/simulator-arm.cc#newcod...
src/arm/simulator-arm.cc:409: } else if (strcmp(cmd, "disasm") == 0 ||
strcmp(cmd, "da")) {
On 2011/03/16 22:28:42, Søren Gjesse wrote:
> Maybe di instead of da?

Done.

[Karl Klose, 2011-03-17 14:23:22]

I uploaded a new patch. The value used as constant pool marker could actually be
a valid instruction, depending on the the 5th bit of the length value.

[Søren Thygesen Gjesse, 2011-03-21 08:08:43]

LGTM