Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Issue 6676035: Made UserImageLoader aware of what image was decoded. (Closed)

Created:
9 years, 9 months ago by whywhat
Modified:
9 years, 7 months ago
Reviewers:
altimofeev
CC:
chromium-reviews, nkostylev+cc_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Changed UserImageLoader so it allows more formats of images and does decoding in sandboxed process. Made UserImageLoader aware of what image was decoded. BUG=chromium-os:2348 TEST=Download images in different formats (i.e. BMP, GIF, JPG, PNG, TIFF) and try to change user picture with these files at chrome://settings/personal Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=78366

Patch Set 1 #

Total comments: 6

Patch Set 2 : Fixed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -40 lines) Patch
M chrome/browser/chromeos/login/captcha_view.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/captcha_view.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/image_decoder.h View 1 4 chunks +12 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/image_decoder.cc View 1 3 chunks +16 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/login/image_downloader.cc View 1 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/chromeos/login/user_image_loader.h View 1 4 chunks +29 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/login/user_image_loader.cc View 1 3 chunks +37 lines, -18 lines 0 comments Download
M chrome/browser/ui/webui/options/personal_options_handler.cc View 1 chunk +11 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
altimofeev
LGTM with comments http://codereview.chromium.org/6676035/diff/1/chrome/browser/chromeos/login/image_decoder.cc File chrome/browser/chromeos/login/image_decoder.cc (right): http://codereview.chromium.org/6676035/diff/1/chrome/browser/chromeos/login/image_decoder.cc#newcode15 chrome/browser/chromeos/login/image_decoder.cc:15: image_data_(image_data), Don't you have one unnecessary ...
9 years, 9 months ago (2011-03-16 10:40:08 UTC) #1
whywhat
http://codereview.chromium.org/6676035/diff/1/chrome/browser/chromeos/login/image_decoder.cc File chrome/browser/chromeos/login/image_decoder.cc (right): http://codereview.chromium.org/6676035/diff/1/chrome/browser/chromeos/login/image_decoder.cc#newcode15 chrome/browser/chromeos/login/image_decoder.cc:15: image_data_(image_data), On 2011/03/16 10:40:09, altimofeev wrote: > Don't you ...
9 years, 9 months ago (2011-03-16 10:45:21 UTC) #2
whywhat
http://codereview.chromium.org/6676035/diff/1/chrome/browser/chromeos/login/image_decoder.cc File chrome/browser/chromeos/login/image_decoder.cc (right): http://codereview.chromium.org/6676035/diff/1/chrome/browser/chromeos/login/image_decoder.cc#newcode15 chrome/browser/chromeos/login/image_decoder.cc:15: image_data_(image_data), Got it. Done. On 2011/03/16 10:45:21, whywhat wrote: ...
9 years, 9 months ago (2011-03-16 13:33:39 UTC) #3
altimofeev
9 years, 9 months ago (2011-03-16 13:55:40 UTC) #4
Thanks! (still LGTM)

Powered by Google App Engine
This is Rietveld 408576698