Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2919)

Unified Diff: chrome/browser/autofill/personal_data_manager_unittest.cc

Issue 6676031: Autofill database migration to clean up bogus profiles. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Move to Lingesh's observer mechanism. Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/autofill/personal_data_manager_unittest.cc
diff --git a/chrome/browser/autofill/personal_data_manager_unittest.cc b/chrome/browser/autofill/personal_data_manager_unittest.cc
index 6ae07e405fbef8c134f79f9771dc4ef4b143de8d..b8907dee6ca7bf9f2f550342658cf151d1c7c185 100644
--- a/chrome/browser/autofill/personal_data_manager_unittest.cc
+++ b/chrome/browser/autofill/personal_data_manager_unittest.cc
@@ -593,8 +593,8 @@ TEST_F(PersonalDataManagerTest, ImportFormDataBadEmail) {
std::vector<const FormStructure*> forms;
forms.push_back(&form_structure);
const CreditCard* imported_credit_card;
- EXPECT_TRUE(personal_data_->ImportFormData(forms, &imported_credit_card));
- ASSERT_FALSE(imported_credit_card);
+ EXPECT_FALSE(personal_data_->ImportFormData(forms, &imported_credit_card));
+ ASSERT_EQ(static_cast<CreditCard*>(NULL), imported_credit_card);
// Wait for the refresh.
EXPECT_CALL(personal_data_observer_,
@@ -602,13 +602,8 @@ TEST_F(PersonalDataManagerTest, ImportFormDataBadEmail) {
MessageLoop::current()->Run();
- AutofillProfile expected;
- autofill_test::SetProfileInfo(&expected, "George", NULL,
- "Washington", NULL, NULL, "21 Laussat St", NULL,
- "San Francisco", "California", "94102", NULL, NULL, NULL);
const std::vector<AutofillProfile*>& results = personal_data_->profiles();
- ASSERT_EQ(1U, results.size());
- EXPECT_EQ(0, expected.Compare(*results[0]));
+ ASSERT_EQ(0U, results.size());
}
TEST_F(PersonalDataManagerTest, ImportFormDataNotEnoughFilledFields) {

Powered by Google App Engine
This is Rietveld 408576698