Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Unified Diff: chrome/default_plugin/plugin_database_handler.cc

Issue 6676030: WinDDK ATL and MSVC express compatability (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: '' Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/default_plugin/plugin_database_handler.cc
===================================================================
--- chrome/default_plugin/plugin_database_handler.cc (revision 78148)
+++ chrome/default_plugin/plugin_database_handler.cc (working copy)
@@ -4,6 +4,11 @@
#include "chrome/default_plugin/plugin_database_handler.h"
+#ifdef COMPILER_MSVCEXPRESS
+#include <atlbase.h>
+#include <atlwin.h> // Avoid WinDDK intsafe.h/XINTXX_MIN/MAX conflicts
+#endif
+
#include "libxml/parser.h"
#include "libxml/xpath.h"
@@ -118,7 +123,7 @@
FILE_SHARE_READ, NULL, CREATE_ALWAYS,
FILE_ATTRIBUTE_NORMAL, NULL);
if (plugin_downloads_file_ == INVALID_HANDLE_VALUE) {
- unsigned long error = ::GetLastError();
+ DWORD error = ::GetLastError();
M-A Ruel 2011/03/16 17:48:55 why?
RN 2011/03/17 06:33:25 It was a lint error. WinSDK GetLastError returns a
if (error == ERROR_SHARING_VIOLATION) {
// File may have been downloaded by another plugin instance on this
// page.

Powered by Google App Engine
This is Rietveld 408576698