Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6176)

Unified Diff: chrome/installer/mini_installer.gyp

Issue 6676030: WinDDK ATL and MSVC express compatability (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: Address comments: -EXPRESS define, memset always implemented, coding style Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/installer/mini_installer.gyp
===================================================================
--- chrome/installer/mini_installer.gyp (revision 78547)
+++ chrome/installer/mini_installer.gyp (working copy)
@@ -58,24 +58,9 @@
'IgnoreAllDefaultLibraries': 'true',
'OptimizeForWindows98': '1',
'SubSystem': '2', # Set /SUBSYSTEM:WINDOWS
- 'conditions': [
- ['MSVS_VERSION=="2010"', {
- 'AdditionalDependencies': [
- # These two object files are included in Visual Studio 2008
- # but not 2010.
- # TODO(bradnelson):
- # http://code.google.com/p/chromium/issues/detail?id=72885
- '"$(VCInstallDir)..\\..\\Microsoft Visual Studio 9.0\\VC\\'
- 'crt\\src\\intel\\mt_lib\\memset.obj"',
- '"$(VCInstallDir)..\\..\\Microsoft Visual Studio 9.0\\VC\\'
- 'crt\\src\\intel\\mt_lib\\P4_memset.obj"',
- ],
- },{
- 'AdditionalDependencies': [
- '"$(VCInstallDir)crt\\src\\intel\\mt_lib\\memset.obj"',
- '"$(VCInstallDir)crt\\src\\intel\\mt_lib\\P4_memset.obj"',
- ],
- }],
+ 'AdditionalDependencies': [
Mark Mentovai 2011/03/17 20:43:42 Did you confirm whether this change results in a m
RN 2011/03/18 09:34:24 I didn't notice a substantial change (maybe saves
+ 'shlwapi.lib',
+ 'setupapi.lib',
],
},
'VCManifestTool': {

Powered by Google App Engine
This is Rietveld 408576698