WinDDK ATL and MSVC express compatability

chrome/browser/ui/views/autocomplete/autocomplete_result_view.cc

Index: chrome/browser/ui/views/autocomplete/autocomplete_result_view.cc
===================================================================
--- chrome/browser/ui/views/autocomplete/autocomplete_result_view.cc	(revision 78547)
+++ chrome/browser/ui/views/autocomplete/autocomplete_result_view.cc	(working copy)
@@ -4,6 +4,11 @@
 
 #include "chrome/browser/ui/views/autocomplete/autocomplete_result_view.h"
 
+#if defined(OS_WIN)

[Mark Mentovai, 2011/03/17 16:54:18]

http://www.chromium.org/developers/coding-style:

#includes should be ordered per Google style, except platform-specific (#if
defined(..)) headers to follow the cross platform headers in a separate section,
e.g.:

#include "foo/bar/someclass.h"

#include <set>

#include "foo/bar/a.h"
#include "foo/bar/b.h"

#if defined(OS_WIN)
#include "foo/bar/a_win.h"
#include "foo/bar/b_win.h"
#elif defined(OS_POSIX)
#include "foo/bar/a_posix.h"
#endif

See also
http://groups.google.com/a/chromium.org/group/chromium-dev/browse_thread/thre...

[RN, 2011/03/17 20:15:11]

Actually, that's what half (or more, may as well name the WinDDK ATL patch with
a few express tweaks on the side) this patch is about, which has nothing to
VCExpress but everything to do with the Windows DDK ATL and WinSDK header
ordering relative to the Chromium header ordering. 

Mentioned several times already; the reason that the ATL headers are placed
where they are is because if the WinDDK ATL headers come after ICU or other
headers that define XINT/ETC_MIN/MAX you're going to get multiple definition
warnings since WinDDK ATL pulls in intsafe.h which doesn't wrap the
XINT/ETC_MIN/MAX definitions around ifdefs. Since a good part of the Chromium
project files have the warnings as errors flag on... well, they turn into
errors.

Third party headers are pulled in first before system headers included by other
project headers all over the place alphabetically. Yes, lint likes this, but
isn't always practical, as WinSDK/DDK and other system headers are _always_
supposed to come before third party headers.

This patch just sticks to the existing Chromium coding style/header ordering as
much as possible while not breaking the WinDDK ATL. That's the reason for
existence of atlcheck.h - to enforce header ordering if one isn't using the
WinDDK ATL and to cause warnings/errors as if you were.

Hopefully that makes sense.

+#include <atlbase.h>
+#include <atlwin.h>
+#endif
+
 #include "base/i18n/bidi_line_iterator.h"
 #include "chrome/browser/ui/views/autocomplete/autocomplete_result_view_model.h"
 #include "chrome/browser/ui/views/location_bar/location_bar_view.h"